From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q3NFlZLJ207973 for ; Mon, 23 Apr 2012 10:47:35 -0500 Message-ID: <4F957998.6010900@sgi.com> Date: Mon, 23 Apr 2012 10:47:36 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 36/37] xfs: flush outstanding buffers on log mount failure References: <1335160747-17254-1-git-send-email-david@fromorbit.com> <1335160747-17254-37-git-send-email-david@fromorbit.com> In-Reply-To: <1335160747-17254-37-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 04/23/12 00:59, Dave Chinner wrote: > From: Dave Chinner > > When we fail to mount the log in xfs_mountfs(), we tear down all the > infrastructure we have already allocated. However, the process of > mounting the log may have progressed to the point of reading, > caching and modifying buffers in memory. Hence before we can free > all the infrastructure, we have to flush and remove all the buffers > from memory. > > Problem first reported by Eric Sandeen, later a different incarnation > was reported by Ben Myers. > > Signed-off-by: Dave Chinner > --- Looks good. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs