Re: [PATCH 37/37] xfs: make XBF_MAPPED the default behaviour

Christoph Hellwig
2012-04-29T21:57:29Z

> @@ -399,8 +399,9 @@ _xfs_buf_map_pages(
> if (bp->b_page_count == 1) {
> /* A single page buffer is always mappable */
> bp->b_addr = page_address(bp->b_pages[0]) + bp->b_offset;
> - bp->b_flags |= XBF_MAPPED;
> - } else if (flags & XBF_MAPPED) {
> + } else if (flags & XBF_UNMAPPED) {
> + bp->b_addr = NULL;

Do we need this explicit assigned? The buffer should always have
b_addr == NULL at this point.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>