Re: [PATCH 34/37] xfs: clean up xfs_bit.h includes

Christoph Hellwig
2012-04-29T21:55:26Z

> * Visible inode allocation functions.
> */
> +/*
> + * Find a free (set) bit in the inode bitmask.
> + */
> +static inline int xfs_ialloc_find_free(xfs_inofree_t *fp)
> +{
> + return xfs_lowbit64(*fp);
> +}

I'd suggest killing this helper entirely - there is just a single
caller, and using the lowbit helper directly actually is even more
obvious.