Re: [PATCH 29/37 V2] xfs: move busy extent handling to it's own file

Mark Tinguely
2012-04-24T18:10:39Z

On 04/24/12 10:56, Mark Tinguely wrote:
> On 04/23/12 19:25, Dave Chinner wrote:
>
> From: Dave Chinner <dchinner@redhat.com>
>
> To make it easier to handle userspace code merges, move all the busy
> extent handling out of the allocation code and into it's own file.
> The userspace code does not need the busy extent code, so this
> simplifies the merging of the kernel code into the userspace
> xfsprogs library.
>
> Because the busy extent code has been almost completely rewritten
> over the past couple of years, also update the copyright on this new
> file to include the authors that made all those changes.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
>
> Should xfs_alloc_busy_trim() be STATIC? It is defined in
> xfs_extent_busy.c and used in xfs_alloc.c.
>
> Same story for the next patch which renames this routine.
>
> Thanks,
>
> Mark Tinguely <tinguely@sgi.com>

FYI,

The routines in this patch call for struct xfs_busy_extent, but the
xfs_extent_busy.h header file defines struct xfs_extent_busy.

I know this structure will get converted for the next patch.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>