Re: [PATCH 36/37] xfs: flush outstanding buffers on log mount failure

Christoph Hellwig
2012-04-29T21:55:57Z

On Mon, Apr 23, 2012 at 03:59:06PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> When we fail to mount the log in xfs_mountfs(), we tear down all the
> infrastructure we have already allocated. However, the process of
> mounting the log may have progressed to the point of reading,
> caching and modifying buffers in memory. Hence before we can free
> all the infrastructure, we have to flush and remove all the buffers
> from memory.
>
> Problem first reported by Eric Sandeen, later a different incarnation
> was reported by Ben Myers.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>