Re: [PATCH 28/37] xfs: move xfsagino_t to xfs_types.h

Dave Chinner
2012-04-30T00:32:36Z

On Sun, Apr 29, 2012 at 05:49:17PM -0400, Christoph Hellwig wrote:
> On Mon, Apr 23, 2012 at 03:58:58PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Untangle the header file includes a bit by moving the definition of
> > xfs_agino_t to xfs_types.h. This removes the dependency that xfs_ag.h has on
> > xfs_inum.h, meaning we don't need to include xfs_inum.h everywhere we include
> > xfs_ag.h.
>
> This patch by itself looks good to me, but is there any good reason to
> keep xfs_inum.h around at all?

I have that same question written down on my todo list. Seems like
most of what remains could be added to xfs_ag.h or similar. One step
at a time ;)

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com