Re: Still seeing hangs in xlog_grant_log_space

Chris J Arges
2012-06-05T15:21:37Z

Peter Watkins-3 wrote:
>
> Does your kernel have the effect of
>
> 0bf6a5bd4b55b466964ead6fa566d8f346a828ee xfs: convert the xfsaild
> thread to a workqueue
>

This patch is present in the Ubuntu Precise 3.2 kernel, and I have been able
to reproduce the failure with this patch applied.

Peter Watkins-3 wrote:
>
> c7eead1e118fb7e34ee8f5063c3c090c054c3820 xfs: revert to using a
> kthread for AIL pushing
>

I see this patch is 0030807c66f058230bcb20d2573bcaf28852e804 upstream, and
this patch is also present in the 3.2 Precise kernel that was tested and
exhibited the failure.

Peter Watkins-3 wrote:
>
> In particular, is this code in xfs_trans_ail_push:
>
> smp_wmb();
> xfs_trans_ail_copy_lsn(ailp, &ailp->xa_target, &threshold_lsn);
> smp_wmb();
>

In fs/xfs/xfs_trans_ail.c:xfs_ail_push():

/*
* Ensure that the new target is noticed in push code before it
clears
* the XFS_AIL_PUSHING_BIT.
*/
smp_wmb();
xfs_trans_ail_copy_lsn(ailp, &ailp->xa_target, &threshold_lsn);
smp_wmb();

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

--
View this message in context: http://old.nabble.com/Still-seeing-hangs-in-xlog_grant_log_space-tp33732886p33964752.html
Sent from the Xfs - General mailing list archive at Nabble.com.