From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q4AJpJJS055035 for ; Thu, 10 May 2012 14:51:19 -0500 Message-ID: <4FAC1C33.5050508@sgi.com> Date: Thu, 10 May 2012 14:51:15 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH] Introduce SEEK_DATA/SEEK_HOLE support v9 References: <4FABC2AD.2030609@oracle.com> In-Reply-To: <4FABC2AD.2030609@oracle.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: jeff.liu@oracle.com Cc: Ben Myers , xfs@oss.sgi.com On 05/10/12 08:29, Jeff Liu wrote: > Hello, > > This is the revised patch according to Mark's comments. > Is it possible to get it to accept if there are no other issues, > so that I can continue to work on the unwritten part based on that. > > Thanks, > -Jeff > > Signed-off-by: Jie Liu > > --- > + > +STATIC loff_t > +xfs_seek_hole( > + struct file *file, > + loff_t start, > + u32 type) > +{ > + struct inode *inode = file->f_mapping->host; > + struct xfs_inode *ip = XFS_I(inode); > + struct xfs_mount *mp = ip->i_mount; > + loff_t uninitialized_var(offset); > + loff_t holeoff; > + xfs_fsize_t isize; > + xfs_fileoff_t fsbno; > + uint lock; > + int error; > + > + if (XFS_FORCED_SHUTDOWN(mp)) > + return -XFS_ERROR(EIO); I think xfs_bmapi_read() returns just a XFS_ERROR(EIO), not negative. Ben can fix up if you agree. Other than that it is a great feature to in XFS. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs