From: Alain Renaud <arenaud@sgi.com>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.
Date: Tue, 22 May 2012 19:35:54 -0400 [thread overview]
Message-ID: <4FBC22DA.4020500@sgi.com> (raw)
In-Reply-To: <20120522232424.GK25351@dastard>
On 12-05-22 07:24 PM, Dave Chinner wrote:
> On Tue, May 22, 2012 at 03:56:21PM -0500, Alain Renaud wrote:
>> This mod simply add a XFS_ prefix to IO_DIRECT,XFS_IO_DELALLOC,
>> XFS_IO_UNWRITTEN and XFS_IO_OVERWRITE. This to avoid namespace conflict
>> with other modules.
> While I don't see any problems with making the change, I don't see
> exactly how we could have a namespace clash here given they are
> internal to XFS, not very widely included and have beenthis way for
> years. What is the namespace clash you are seeing/caring about?
>
> Cheers,
>
> Dave.
>
Hi Dave,
Looking at the XFS code in general we do tend to prefix XFS specific macro
with XFS_ . I did hit the name conflict with one of our internal module I
did fix our module to prefix with the module name but I thought since I did
hit the problem that maybe other people might have the same issue. This is
why I am proposing this mod. it is low priority but I find it is a little
cleaner to have this prefix.
Hope this make sense.
Alain
--
===============================================
Alain Renaud - Cluster File System Engineer
arenaud@sgi.com - SGI
===============================================
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-05-22 23:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 20:56 [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision Alain Renaud
2012-05-22 23:24 ` Dave Chinner
2012-05-22 23:35 ` Alain Renaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBC22DA.4020500@sgi.com \
--to=arenaud@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox