From: Mark Tinguely <tinguely@sgi.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC PATCH v3 2/2] xfs: fix xfsaild hang due to lost wake ups
Date: Wed, 23 May 2012 13:19:31 -0500 [thread overview]
Message-ID: <4FBD2A33.8080403@sgi.com> (raw)
In-Reply-To: <4FBD2306.8090000@redhat.com>
On 05/23/12 12:48, Brian Foster wrote:
> On 05/22/2012 08:58 PM, Dave Chinner wrote:
> snip
>>
>> Finally, rather than calling wake_up_process() in the
>> xfs_ail_push*() functions, call wake_up(&ailp->xa_idle); There can
>> only be one thread sleeping on that (the xfsaild) so there is no
>> need to use the wake_up_all() variant...
>>
>> FWIW, you might be able to do this without the idle wait queue and
>> just use wake_up_process() -
>>
>
> Hi Dave,
>
> I have a working version of your suggested algorithm. It looks mostly the same with the exception of a spin_unlock fix. I also have the below version that uses a wait_queue and that I plan to test overnight tonight:
>
...
FYI. Test 273 in a loop will still cause the sync_worker to lock when it
tries to allocate a dummy transaction.
PID: 29214 TASK: ffff8807e66404c0 CPU: 1 COMMAND: "kworker/1:15"
#0 [ffff88081f551b60] __schedule at ffffffff814175d0
#1 [ffff88081f551ca8] schedule at ffffffff81417944
#2 [ffff88081f551cb8] xlog_grant_head_wait at ffffffffa055a6d5 [xfs]
#3 [ffff88081f551d08] xlog_grant_head_check at ffffffffa055a856 [xfs]
#4 [ffff88081f551d48] xfs_log_reserve at ffffffffa055a95f [xfs]
#5 [ffff88081f551d88] xfs_trans_reserve at ffffffffa0557ee4 [xfs]
#6 [ffff88081f551dd8] xfs_fs_log_dummy at ffffffffa050cf88 [xfs]
#7 [ffff88081f551df8] xfs_sync_worker at ffffffffa0518454 [xfs]
#8 [ffff88081f551e18] process_one_work at ffffffff810564ad
#9 [ffff88081f551e68] worker_thread at ffffffff81059203
#10 [ffff88081f551ee8] kthread at ffffffff8105dd2e
#11 [ffff88081f551f48] kernel_thread_helper at ffffffff81421a64
I understand why the dummy transaction was added and I think we can
anticipate the hang before it happens and avoid it.
--Mark T.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-05-23 18:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 16:38 [RFC PATCH v3 0/2] xfs: fix xfsaild races and re-enable idle mode Brian Foster
2012-05-22 16:38 ` [RFC PATCH v3 1/2] xfs: re-enable xfsaild idle mode when the ail is empty Brian Foster
2012-05-22 16:38 ` [RFC PATCH v3 2/2] xfs: fix xfsaild hang due to lost wake ups Brian Foster
2012-05-23 0:58 ` Dave Chinner
2012-05-23 13:05 ` Brian Foster
2012-05-24 0:01 ` Dave Chinner
2012-05-23 17:48 ` Brian Foster
2012-05-23 18:19 ` Mark Tinguely [this message]
2012-05-23 23:41 ` Brian Foster
2012-05-23 23:53 ` Dave Chinner
2012-05-24 14:38 ` Mark Tinguely
2012-05-24 0:06 ` Dave Chinner
2012-05-24 13:07 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBD2A33.8080403@sgi.com \
--to=tinguely@sgi.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox