From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q4TFb1N4243888 for ; Tue, 29 May 2012 10:37:01 -0500 Message-ID: <4FC4ED13.6030904@redhat.com> Date: Tue, 29 May 2012 11:36:51 -0400 From: Brian Foster MIME-Version: 1.0 Subject: Re: [PATCH] xfs: shutdown xfs_sync_worker before the log References: <20120323174327.GU7762@sgi.com> <20120514203449.GE16099@sgi.com> <20120516015626.GN25351@dastard> <20120516170402.GD3963@sgi.com> <20120517071658.GP25351@dastard> <20120524223952.GU16099@sgi.com> <20120525204536.GA4721@sgi.com> <20120529150715.GB4721@sgi.com> In-Reply-To: <20120529150715.GB4721@sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Ben Myers Cc: xfs@oss.sgi.com On 05/29/2012 11:07 AM, Ben Myers wrote: > On Fri, May 25, 2012 at 03:45:36PM -0500, Ben Myers wrote: >> On Thu, May 24, 2012 at 05:39:52PM -0500, Ben Myers wrote: >>> Anyway, I'll make some time to work on this tomorrow so I can test it over >>> the weekend. >> >> This is going to spin over the weekend. See what you think. > > I'm reasonably satisfied with the test results over the weekend. I did end up > hitting an unrelated assert: > I started testing the xfsaild idle patch based against the xfs tree over the weekend (after testing successfully against Linus' tree for several days) and reproduced the xfs_sync_worker() hang that Mark alerted me to last week. I was considering doing a bisect in that tree since it doesn't occur in Linus' tree, but it sounds like I can pull this patch now and shouldn't expect to reproduce the sync_worker() hang either, correct? Thanks. Brian > [137111.090394] XFS: Assertion failed: (iflags & BMV_IF_DELALLOC) != 0, file: /root/xfs/fs/xfs/xfs_bmap.c, line: 5635 > > Signed-off-by: Ben Myers > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs