From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] Printk for ENOSPC due to lack of inodes
Date: Thu, 31 May 2012 22:31:21 -0500 [thread overview]
Message-ID: <4FC83789.8010900@sandeen.net> (raw)
In-Reply-To: <20120531193616.GA3953@Xye.local>
On 5/31/12 2:36 PM, Raghavendra D Prabhu wrote:
> Hi,
>
> Thanks for the review. I have now moved it inside xfs_dialloc. Along with adding the message, I noticed that the loop
>
> while (!agi->agi_freecount) {
> }
>
> is redundant when noroom=1 and okalloc=0.
>
> Also, xfs_ialloc_ag_alloc function in the loop calls
> ============
> if (mp->m_maxicount &&
> mp->m_sb.sb_icount + XFS_IALLOC_INODES(mp) > mp->m_maxicount) {
>
> ===============
>
> condition again.
>
> So I have moved xfs_tran_brelse etc. into the condition along with message.
>
> Is this logic valid? If it is, then I will look into rate-limiting the message etc.
It'd be easiest to understand this new change as a patch rather than as a description.
If you are changing logic or flow in addition to adding the messages, it should almost certainly be sent as more than one patch.
Thanks,
-eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-06-01 3:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 0:37 [PATCH] Printk for ENOSPC due to lack of inodes Raghavendra D Prabhu
2012-03-07 17:39 ` Eric Sandeen
2012-05-31 19:36 ` Raghavendra D Prabhu
2012-06-01 3:31 ` Eric Sandeen [this message]
2012-06-01 6:07 ` Raghavendra D Prabhu
2012-06-05 6:46 ` Raghavendra D Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC83789.8010900@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox