* [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent()
@ 2012-06-08 19:32 Eric Sandeen
2012-06-08 19:44 ` Ben Myers
2012-06-08 23:12 ` Dave Chinner
0 siblings, 2 replies; 4+ messages in thread
From: Eric Sandeen @ 2012-06-08 19:32 UTC (permalink / raw)
To: xfs-oss
w/o this change I was getting:
[ 742.376495] ODEBUG: object is on stack, but not annotated
[ 742.377007] ------------[ cut here ]------------
[ 742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
...
[ 742.377007] Call Trace:
[ 742.377007] [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
[ 742.377007] [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
[ 742.377007] [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
[ 742.377007] [<ffffffff8133689f>] debug_object_init+0x1f/0x30
[ 742.377007] [<ffffffff81081cd9>] __init_work+0x19/0x30
[ 742.377007] [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
on a debug 3.4 kernel.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I think it's right? :)
diff --git a/fs/xfs/xfs_alloc.c b/fs/xfs/xfs_alloc.c
index 0f0df27..0be396d 100644
--- a/fs/xfs/xfs_alloc.c
+++ b/fs/xfs/xfs_alloc.c
@@ -2443,7 +2443,7 @@ xfs_alloc_vextent(
DECLARE_COMPLETION_ONSTACK(done);
args->done = &done;
- INIT_WORK(&args->work, xfs_alloc_vextent_worker);
+ INIT_WORK_ONSTACK(&args->work, xfs_alloc_vextent_worker);
queue_work(xfs_alloc_wq, &args->work);
wait_for_completion(&done);
return args->result;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent()
2012-06-08 19:32 [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent() Eric Sandeen
@ 2012-06-08 19:44 ` Ben Myers
2012-06-08 23:12 ` Dave Chinner
1 sibling, 0 replies; 4+ messages in thread
From: Ben Myers @ 2012-06-08 19:44 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Fri, Jun 08, 2012 at 02:32:42PM -0500, Eric Sandeen wrote:
> w/o this change I was getting:
>
> [ 742.376495] ODEBUG: object is on stack, but not annotated
> [ 742.377007] ------------[ cut here ]------------
> [ 742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
> ...
> [ 742.377007] Call Trace:
> [ 742.377007] [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
> [ 742.377007] [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
> [ 742.377007] [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
> [ 742.377007] [<ffffffff8133689f>] debug_object_init+0x1f/0x30
> [ 742.377007] [<ffffffff81081cd9>] __init_work+0x19/0x30
> [ 742.377007] [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
>
> on a debug 3.4 kernel.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks pretty good. ;)
Reviewed-by: Ben Myers <bpm@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent()
2012-06-08 19:32 [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent() Eric Sandeen
2012-06-08 19:44 ` Ben Myers
@ 2012-06-08 23:12 ` Dave Chinner
2012-06-08 23:14 ` Eric Sandeen
1 sibling, 1 reply; 4+ messages in thread
From: Dave Chinner @ 2012-06-08 23:12 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Fri, Jun 08, 2012 at 02:32:42PM -0500, Eric Sandeen wrote:
> w/o this change I was getting:
>
> [ 742.376495] ODEBUG: object is on stack, but not annotated
> [ 742.377007] ------------[ cut here ]------------
> [ 742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
> ...
> [ 742.377007] Call Trace:
> [ 742.377007] [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
> [ 742.377007] [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
> [ 742.377007] [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
> [ 742.377007] [<ffffffff8133689f>] debug_object_init+0x1f/0x30
> [ 742.377007] [<ffffffff81081cd9>] __init_work+0x19/0x30
> [ 742.377007] [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
>
> on a debug 3.4 kernel.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Already posted by Jeff twice - I picked this up and started testing
it a couple of days ago:
http://marc.info/?l=linux-fsdevel&m=133877118608852&w=2
http://oss.sgi.com/archives/xfs/2012-06/msg00081.html
Sorry to burst you bubble, Eric, but I think Jeff gets this one. ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent()
2012-06-08 23:12 ` Dave Chinner
@ 2012-06-08 23:14 ` Eric Sandeen
0 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2012-06-08 23:14 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs-oss
On 6/8/12 6:12 PM, Dave Chinner wrote:
> On Fri, Jun 08, 2012 at 02:32:42PM -0500, Eric Sandeen wrote:
>> w/o this change I was getting:
>>
>> [ 742.376495] ODEBUG: object is on stack, but not annotated
>> [ 742.377007] ------------[ cut here ]------------
>> [ 742.377007] WARNING: at lib/debugobjects.c:302 __debug_object_init+0x1c0/0x3d0()
>> ...
>> [ 742.377007] Call Trace:
>> [ 742.377007] [<ffffffff81060dbf>] warn_slowpath_common+0x7f/0xc0
>> [ 742.377007] [<ffffffff81060e1a>] warn_slowpath_null+0x1a/0x20
>> [ 742.377007] [<ffffffff81336640>] __debug_object_init+0x1c0/0x3d0
>> [ 742.377007] [<ffffffff8133689f>] debug_object_init+0x1f/0x30
>> [ 742.377007] [<ffffffff81081cd9>] __init_work+0x19/0x30
>> [ 742.377007] [<ffffffffa0299f81>] xfs_alloc_vextent+0x101/0x190 [xfs]
>>
>> on a debug 3.4 kernel.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Already posted by Jeff twice - I picked this up and started testing
> it a couple of days ago:
>
> http://marc.info/?l=linux-fsdevel&m=133877118608852&w=2
> http://oss.sgi.com/archives/xfs/2012-06/msg00081.html
>
> Sorry to burst you bubble, Eric, but I think Jeff gets this one. ;)
sigh. Can't keep up. But I try!
-Eric
> Cheers,
>
> Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-08 23:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-08 19:32 [PATCH] xfs: use INIT_WORK_ONSTACK in xfs_alloc_vextent() Eric Sandeen
2012-06-08 19:44 ` Ben Myers
2012-06-08 23:12 ` Dave Chinner
2012-06-08 23:14 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox