From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q63BpXCa086260 for ; Tue, 3 Jul 2012 06:51:33 -0500 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id a8xOsGyfvwUUGtaX for ; Tue, 03 Jul 2012 04:51:32 -0700 (PDT) Message-ID: <4FF2DCB1.2090704@redhat.com> Date: Tue, 03 Jul 2012 13:51:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 Subject: Re: [dm-devel] [PATCH v2 1/3] block: add sysfs entry for discard_alignment References: <1341235225-27551-1-git-send-email-pbonzini@redhat.com> <1341235225-27551-2-git-send-email-pbonzini@redhat.com> <20120703023442.GB3586@redhat.com> In-Reply-To: <20120703023442.GB3586@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Vivek Goyal Cc: axboe@kernel.dk, martin.petersen@oracle.com, snitzer@redhat.com, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, dm-devel@redhat.com, hch@lst.de Il 03/07/2012 04:34, Vivek Goyal ha scritto: >> > The next patches will actually use the alignment, expose it in sysfs >> > for ease of debugging. >> > > Don't we already have discard_alignment exported as device attribute. > > /sys/block//discard_alignment Ah, interesting, I missed it completely. I guess it's because queue/ directories only exist for full disks, and the correct alignment varies for each partition. So this patch is unnecessary. Paolo _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs