From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q63F6pZe101199 for ; Tue, 3 Jul 2012 10:06:51 -0500 Message-ID: <4FF30A89.9010800@sgi.com> Date: Tue, 03 Jul 2012 10:06:49 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH] xfstests: improve test 286 for repeated unwritten/hole extents. References: <4FF29F94.6030702@oracle.com> In-Reply-To: <4FF29F94.6030702@oracle.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: jeff.liu@oracle.com Cc: xfs@oss.sgi.com On 07/03/12 02:30, Jeff Liu wrote: > Hello, > > I'd like to enlarge the test coverage of 286 to includes file mapping with repeated hole/unwritten/unwritten_without_data/data intersections. > > Those two new sub-tests could help verifying the current seek_data/seek_hole improvements. > > Besides, I observed a weird thing at the diff of 286.full, look at the the sparse file creation output, there seems to be a significant > I/O degradation compare to the old test01/test02 IOPS results: > > -1 MiB, 256 ops; 0.0000 sec (1.242 GiB/sec and 325699.7455 ops/sec) > +1 MiB, 256 ops; 0.0000 sec (70.161 MiB/sec and 17961.1310 ops/sec) > > I run the test on same machine and same partition, I recalled the old result is generated against around 3.4-rc2(not very sure), now is updated > to 3.5-rc4, does anyone hit that? > > Quick feedback. I don't see any degradation. OLD: 1 MiB, 256 ops; 0.0000 sec (484.027 MiB/sec and 123910.9390 ops/sec) THIS: 1 MiB, 256 ops; 0.0000 sec (494.560 MiB/sec and 126607.3195 ops/sec) All the tests are very close to the unpatched results. > Signed-off-by: Jie Liu > > --- > 286 | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 286.full | 82 +++++++++++++++++++++++++++++++++++---------------------- Please, drop the 286.full patch. --Mark Tinguely. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs