From: Eric Sandeen <sandeen@sandeen.net>
To: Eryu Guan <eguan@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: common.attr: get block size of test fs not root fs
Date: Tue, 03 Jul 2012 22:09:34 -0500 [thread overview]
Message-ID: <4FF3B3EE.30005@sandeen.net> (raw)
In-Reply-To: <1341226215-16674-1-git-send-email-eguan@redhat.com>
On 7/2/12 5:50 AM, Eryu Guan wrote:
> stat -f $TEST_DEV shows block size of the fs where $TEST_DEV
> resides, usually it is the root fs. This will fail 020 on non-4096 block
> size ext2/3/4, also 4096 block size ext2/3/4 on ppc64.
>
> Instead, stat -f $TEST_DIR will show block size of the fs to be tested.
>
> Tested and passed on ext2/3/4, xfs, btrfs with all supported block size.
>
> Cc: Eric Sandeen <esandeen@redhat.com>
> Signed-off-by: Eryu Guan <eguan@redhat.com>
Whoops, thanks.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
I'll merge it shortly
> ---
> common.attr | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/common.attr b/common.attr
> index 0f1e789..6e2c004 100644
> --- a/common.attr
> +++ b/common.attr
> @@ -187,7 +187,7 @@ _sort_getfattr_output()
> if [ "$FSTYP" == "xfs" -o "$FSTYP" == "udf" ]; then
> MAX_ATTRS=1000
> else # Assume max ~1 block of attrs
> - BLOCK_SIZE=`stat -f $TEST_DEV | grep "Block size" | cut -d " " -f3`
> + BLOCK_SIZE=`stat -f $TEST_DIR | grep "Block size" | cut -d " " -f3`
> # user.attribute_XXX="value.XXX" is about 32 bytes; leave some overhead
> let MAX_ATTRS=$BLOCK_SIZE/40
> fi
> @@ -198,7 +198,7 @@ export MAX_ATTRS
> if [ "$FSTYP" == "xfs" -o "$FSTYP" == "udf" -o "$FSTYP" == "btrfs" ]; then
> MAX_ATTRVAL_SIZE=64
> else # Assume max ~1 block of attrs
> - BLOCK_SIZE=`stat -f $TEST_DEV | grep "Block size" | cut -d " " -f3`
> + BLOCK_SIZE=`stat -f $TEST_DIR | grep "Block size" | cut -d " " -f3`
> # leave a little overhead
> let MAX_ATTRVAL_SIZE=$BLOCK_SIZE-256
> fi
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-07-04 3:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 10:50 [PATCH] xfstests: common.attr: get block size of test fs not root fs Eryu Guan
2012-07-04 3:09 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF3B3EE.30005@sandeen.net \
--to=sandeen@sandeen.net \
--cc=eguan@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox