Re: [PATCH 10/17] rnbd-srv: use bio_add_virt_nofail

Jinpu Wang
2025-04-24T07:14:55Z

On Tue, Apr 22, 2025 at 4:27 PM Christoph Hellwig <hch@lst.de> wrote:
>
> Use the bio_add_virt_nofail to add a single kernel virtual address
> to a bio as that can't fail.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Jack Wang <jinpu.wang@ionos.com>
> ---
> drivers/block/rnbd/rnbd-srv.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/block/rnbd/rnbd-srv.c b/drivers/block/rnbd/rnbd-srv.c
> index 2ee6e9bd4e28..2df8941a6b14 100644
> --- a/drivers/block/rnbd/rnbd-srv.c
> +++ b/drivers/block/rnbd/rnbd-srv.c
> @@ -147,12 +147,7 @@ static int process_rdma(struct rnbd_srv_session *srv_sess,
>
> bio = bio_alloc(file_bdev(sess_dev->bdev_file), 1,
> rnbd_to_bio_flags(le32_to_cpu(msg->rw)), GFP_KERNEL);
> - if (bio_add_page(bio, virt_to_page(data), datalen,
> - offset_in_page(data)) != datalen) {
> - rnbd_srv_err_rl(sess_dev, "Failed to map data to bio\n");
> - err = -EINVAL;
> - goto bio_put;
> - }
> + bio_add_virt_nofail(bio, data, datalen);
>
> bio->bi_opf = rnbd_to_bio_flags(le32_to_cpu(msg->rw));
> if (bio_has_data(bio) &&
> --
> 2.47.2
>