From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: handle EOF correctly in xfs_vm_writepage
Date: Mon, 16 Jul 2012 11:05:38 -0500 [thread overview]
Message-ID: <50043BD2.7080105@sgi.com> (raw)
In-Reply-To: <20120703162000.GA13016@infradead.org>
On 07/03/12 11:20, Christoph Hellwig wrote:
> We need to zero out part of a page which beyond EOF before setting uptodate,
> otherwise, mapread or write will see non-zero data beyond EOF.
>
> Based on the code in fs/buffer.c and the following ext4 commit:
>
> ext4: handle EOF correctly in ext4_bio_write_page()
>
> And yes, I wish we had a good test case for it.
>
> Signed-off-by: Christoph Hellwig<hch@lst.de>
>
> ---
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-07-16 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 16:20 [PATCH] xfs: handle EOF correctly in xfs_vm_writepage Christoph Hellwig
2012-07-16 16:05 ` Mark Tinguely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50043BD2.7080105@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox