From: Rich Johnston <rjohnston@sgi.com>
Cc: xfs@oss.sgi.com, Alain Renaud <arenaud@sgi.com>
Subject: Re: Re: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace colision.
Date: Fri, 20 Jul 2012 07:40:25 -0500 [thread overview]
Message-ID: <500951B9.7030009@sgi.com> (raw)
In-Reply-To: <50095108.9010801@sgi.com>
Sorry resent because I fat fingered the oss address.
On 07/20/2012 07:37 AM, Rich Johnston wrote:
> On 05/22/2012 03:56 PM, Alain Renaud wrote:
>> From: Alain Renaud <arenaud@sgi.com>
>> To: xfs@oss.sgi.com
>> Subject: [PATCH] Prefix IO_XX flags with XFS_IO_XX to avoid namespace
>> colision.
>> User-Agent: Heirloom mailx 12.2 01/07/07
>>
>>
>> This mod simply add a XFS_ prefix to IO_DIRECT,XFS_IO_DELALLOC,
>> XFS_IO_UNWRITTEN and XFS_IO_OVERWRITE. This to avoid namespace conflict
>> with other modules.
>>
>> Signed-off-by: Alain Renaud <arenaud@sgi.com>
>>
>> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
>> index ae31c31..7d3f6ab 100644
>> --- a/fs/xfs/xfs_aops.c
>> +++ b/fs/xfs/xfs_aops.c
>> ...
> > ...
>> diff --git a/fs/xfs/xfs_aops.h b/fs/xfs/xfs_aops.h
>> index 84eafbc..c325abb 100644
>> --- a/fs/xfs/xfs_aops.h
>> +++ b/fs/xfs/xfs_aops.h
>> @@ -24,17 +24,17 @@ extern mempool_t *xfs_ioend_pool;
>> * Types of I/O for bmap clustering and I/O completion tracking.
>> */
>> enum {
>> - IO_DIRECT = 0, /* special case for direct I/O ioends */
>> - IO_DELALLOC, /* mapping covers delalloc region */
>> - IO_UNWRITTEN, /* mapping covers allocated but uninitialized
>> data */
>> - IO_OVERWRITE, /* mapping covers already allocated extent */
>> + XFS_IO_DIRECT = 0, /* special case for direct I/O ioends */
>> + XFS_IO_DELALLOC, /* covers delalloc region */
>> + XFS_IO_UNWRITTEN, /* covers allocated but uninitialized data */
>> + XFS_IO_OVERWRITE, /* covers already allocated extent */
>> };
>>
>> #define XFS_IO_TYPES \
>> { 0, "" }, \
>> - { IO_DELALLOC, "delalloc" }, \
>> - { IO_UNWRITTEN, "unwritten" }, \
>> - { IO_OVERWRITE, "overwrite" } > + {
>> XFS_IO_DELALLOC, "delalloc" }, \
>> + { XFS_IO_UNWRITTEN, "unwritten" }, \
>> + { XFS_IO_OVERWRITE, "overwrite" }
>>
>> /*
>> * xfs_ioend struct manages large extent writes for XFS.
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>>
>
> Alain looks like this patch does what claims to do :), looks good to me.
>
> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
parent reply other threads:[~2012-07-20 12:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <50095108.9010801@sgi.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500951B9.7030009@sgi.com \
--to=rjohnston@sgi.com \
--cc=arenaud@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox