public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <tinguely@sgi.com>
To: jeff.liu@oracle.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v4] xfs: probe data buffer from page cache for unwritten extents
Date: Fri, 20 Jul 2012 13:46:30 -0500	[thread overview]
Message-ID: <5009A786.3080500@sgi.com> (raw)
In-Reply-To: <50091696.4000903@oracle.com>

On 07/20/12 03:28, Jeff Liu wrote:
> Hi All,
>
> According to Mark and Christoph's comments for v3, except optimizing xfs_seek_data() with unwritten extents
> probing, the xfs_seek_hole() is also refined to that in this version.
>
>

Just some feedback.

Test program fragment:

         ret = do_fallocate(fd, 512*1024, 256*1024, 0);
         if (ret < 0)
                 goto out;
         pwrite(fd, buf, 4096, 1024*516);
         lseek(fd, 800*1024, SEEK_SET);
         ret = write(fd, buf, bufsz);
         if (ret < 0)
                 goto out;

Output:

HOLE/DATA at 512K 786432 / 528384   <- undiscovered hole here
HOLE/DATA at 516K 786432 / 528384   <- okay, data but we should
                                         return next page as hole.
HOLE/DATA at 520K 532480 / 819200   <- hole is discovered because
                                        there is no trailing data

--Mark.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-07-20 18:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20  8:28 [PATCH v4] xfs: probe data buffer from page cache for unwritten extents Jeff Liu
2012-07-20 18:46 ` Mark Tinguely [this message]
2012-07-21  6:24   ` Jie Liu
2012-07-22  4:57     ` Christoph Hellwig
2012-07-22  5:29       ` Jie Liu
2012-07-22  6:28         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5009A786.3080500@sgi.com \
    --to=tinguely@sgi.com \
    --cc=jeff.liu@oracle.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox