From: Jie Liu <jeff.liu@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Mark Tinguely <tinguely@sgi.com>, xfs@oss.sgi.com
Subject: Re: [PATCH v4] xfs: probe data buffer from page cache for unwritten extents
Date: Sun, 22 Jul 2012 13:29:14 +0800 [thread overview]
Message-ID: <500B8FAA.8030804@oracle.com> (raw)
In-Reply-To: <20120722045703.GA17235@infradead.org>
Hi Christoph,
On 07/22/2012 12:57 PM, Christoph Hellwig wrote:
> On Sat, Jul 21, 2012 at 02:24:36PM +0800, Jie Liu wrote:
>>> Output:
>>>
>>> HOLE/DATA at 512K 786432 / 528384 <- undiscovered hole here
>>> HOLE/DATA at 516K 786432 / 528384 <- okay, data but we should
>>> return next page as hole.
>>> HOLE/DATA at 520K 532480 / 819200 <- hole is discovered because
>>> there is no trailing data
>> Oops! for xfs_seek_hole(), I should use min_t() to pre-claculate
>> offset before searching page cache.
>> Thanks for your prompt feedback. I'll do some extra tests and post
>> the revised soon.
> Yes, the above test cases should go into xfstests.
Should we keep 285 unchanged and introduce a new test 28? which is
dedicated to ensuring the refinements works as expected?
I have added some new test cases to Mark's test program yesterday, looks
it will grow even bigger if I can think out some other
corner cases(will send them to Mark).
Thanks,
-Jeff
>
> Thanks to both of you to spend all the effort on this feature.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-07-22 5:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-20 8:28 [PATCH v4] xfs: probe data buffer from page cache for unwritten extents Jeff Liu
2012-07-20 18:46 ` Mark Tinguely
2012-07-21 6:24 ` Jie Liu
2012-07-22 4:57 ` Christoph Hellwig
2012-07-22 5:29 ` Jie Liu [this message]
2012-07-22 6:28 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500B8FAA.8030804@oracle.com \
--to=jeff.liu@oracle.com \
--cc=hch@infradead.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox