public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC] [PATCH 0/18] xfstests: move tests out of top level
Date: Wed, 15 Aug 2012 12:23:01 -0500	[thread overview]
Message-ID: <502BDAF5.8040100@sgi.com> (raw)
In-Reply-To: <20120814213929.GN2877@dastard>

On 08/14/12 16:39, Dave Chinner wrote:
> Ping?
>
> On Thu, Jul 26, 2012 at 07:27:54PM +1000, Dave Chinner wrote:
>> Alt-Subject: Games with Sed, Grep and Awk.
>>
>> This series is based on top of the large filesystem test series.
>>
>> This moves all the tests into a ./tests subdirectory, and sorts them into
>> classes of related tests. Those are:
>>
>> 	tests/generic:	valid for all filesystems
>> 	tests/shared:	valid for a limited number of filesystems
>> 	tests/xfs:	xfs specific tests
>> 	tests/btrfs	btrfs specific tests
>> 	tests/ext4	ext4 specific tests
>> 	tests/udf	udf specific tests
>>
>> Each directory has it's own group file to determine what groups the
>> tests are associated with. Tests are run in exactly the same was as
>> before, but when trying to run individual tests you need to specify
>> the class as well. e.g. the old way:
>>
>> # ./check 001
>>
>> The new way:
>>
>> # ./check generic/001

I applied the series and started a closer look. I like what you have done.

As far as RFC, the only concern that I have heard so far is the desire 
to see benchmarking in the test suite.

--Mark.



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-08-15 17:23 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-26  9:27 [RFC] [PATCH 0/18] xfstests: move tests out of top level Dave Chinner
2012-07-26  9:27 ` [PATCH 01/18] xfstests: remove remake script Dave Chinner
2012-08-28 19:50   ` Christoph Hellwig
2012-07-26  9:27 ` [PATCH 02/18] xfstests: remove bench infrastructure Dave Chinner
2012-07-26  9:27 ` [PATCH 03/18] xfstests: kill useless test owner fields Dave Chinner
2012-08-28 19:51   ` Christoph Hellwig
2012-07-26  9:27 ` [PATCH 04/18] xfstests: remove stale machine configs Dave Chinner
2012-08-28 19:51   ` Christoph Hellwig
2012-07-26  9:27 ` [PATCH 05/18] xfstests: fold common into check Dave Chinner
2012-08-28 19:52   ` Christoph Hellwig
2012-07-26  9:28 ` [PATCH 06/18] xfstests: clean up and simply check CLI option parsing Dave Chinner
2012-08-28 19:52   ` Christoph Hellwig
2012-07-26  9:28 ` [PATCH 07/18] xfstests: kill hangcheck stuff from check Dave Chinner
2012-08-28 19:53   ` Christoph Hellwig
2012-07-26  9:28 ` [PATCH 08/18] xfstests: remove test expunge file support Dave Chinner
2012-08-28 19:54   ` Christoph Hellwig
2012-07-26  9:28 ` [PATCH 09/18] xfstests: remove undocumented TESTS_REMAINING_LOG Dave Chinner
2012-08-28 19:54   ` Christoph Hellwig
2012-07-26  9:28 ` [PATCH 10/18] xfstests: include test subdirectory support Dave Chinner
2012-07-26  9:28 ` [PATCH 11/18] xfstests: move generic tests out of top level dir Dave Chinner
2012-07-26  9:28 ` [PATCH 12/18] xfstests: move xfs specific tests out of top directory Dave Chinner
2012-07-26  9:28 ` [PATCH 13/18] xfstests: move remaining tests out of top level directory Dave Chinner
2012-07-26  9:28 ` [PATCH 14/18] xfstests: rework CLI individual test specification Dave Chinner
2012-07-26  9:28 ` [PATCH 15/18] xfstests: make exclude groups aware of multiple subdirectories Dave Chinner
2012-07-26  9:28 ` [PATCH 16/18] xfstests: Introduce a results directory Dave Chinner
2012-07-26  9:28 ` [PATCH 17/18] xfstests: convert tests to use new " Dave Chinner
2012-09-05 12:00   ` Boris Ranto
2012-09-05 23:04     ` Dave Chinner
2012-09-06 12:34       ` Boris Ranto
2012-09-06 23:14         ` Dave Chinner
2012-09-07 12:47           ` Boris Ranto
2012-07-26  9:28 ` [PATCH 18/18] xfstests: fix _link_out_file callers Dave Chinner
2012-08-14 21:39 ` [RFC] [PATCH 0/18] xfstests: move tests out of top level Dave Chinner
2012-08-15 17:23   ` Mark Tinguely [this message]
2012-08-20 21:27 ` Mark Tinguely
2012-08-20 22:43   ` Dave Chinner
2012-08-21 16:33     ` Ben Myers
2012-08-21 22:09       ` Dave Chinner
2012-08-22 19:16         ` Ben Myers
2012-08-22 23:42           ` Dave Chinner
2012-08-23 17:00             ` Ben Myers
2012-08-24  4:07               ` Dave Chinner
2012-08-28 17:43                 ` Ben Myers
2012-08-28 18:02                   ` Christoph Hellwig
2013-02-25 15:50               ` Eric Sandeen
2013-02-25 21:52                 ` Dave Chinner
2013-02-26  0:27                   ` Theodore Ts'o
2013-02-26  3:18                     ` Dave Chinner
2013-02-26  3:22                     ` Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=502BDAF5.8040100@sgi.com \
    --to=tinguely@sgi.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox