From: Rich Johnston <rjohnston@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] xfstests: test 110 sometimes fails to unmount scratch dev
Date: Thu, 16 Aug 2012 14:16:19 -0500 [thread overview]
Message-ID: <502D4703.3010603@sgi.com> (raw)
In-Reply-To: <1343291706-14882-2-git-send-email-david@fromorbit.com>
On 07/26/2012 03:35 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> It runs a bunch of rm processes in the background, then immediately
> calls _check_scratch_fs without waiting for them to complete, hence
> the unmount can fail with a busy filesystem error.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> 110 | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/110 b/110
> index aad5835..c58e6c9 100755
> --- a/110
> +++ b/110
> @@ -69,6 +69,7 @@ do
> let I=$I+1
> [ $[$I % 1000] -eq 0 ] && echo "Created $I/$E"
> done
#RCJ Yes wait for rm processes to complete
> +wait
>
> sync
>
>
Looks good to me.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-08-16 19:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 8:35 [PATCH 0/4] xfstests: random fixes and improvements Dave Chinner
2012-07-26 8:35 ` [PATCH 1/4] xfstests: test 110 sometimes fails to unmount scratch dev Dave Chinner
2012-08-16 19:16 ` Rich Johnston [this message]
2012-08-28 20:06 ` Christoph Hellwig
2012-08-28 20:20 ` Ben Myers
2012-07-26 8:35 ` [PATCH 2/4] xfstests: loop devices vs umount stupidity Dave Chinner
2012-08-16 19:16 ` Rich Johnston
2012-08-16 22:27 ` Dave Chinner
2012-08-17 12:45 ` Rich Johnston
2012-08-28 20:06 ` Christoph Hellwig
2012-07-26 8:35 ` [PATCH 3/4] xfstests: _check_quota_usage needs to unmount to get XFS quotacheck Dave Chinner
2012-07-26 22:55 ` Dave Chinner
2012-08-16 19:16 ` Rich Johnston
2012-08-28 20:07 ` Christoph Hellwig
2012-07-26 8:35 ` [PATCH 4/4] xfstests: speed up 227 by using preallocation Dave Chinner
2012-08-16 19:16 ` Rich Johnston
2012-08-28 20:07 ` Christoph Hellwig
2012-08-14 21:39 ` [PATCH 0/4] xfstests: random fixes and improvements Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=502D4703.3010603@sgi.com \
--to=rjohnston@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox