* Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
@ 2013-10-10 13:38 Colin Watson
2013-10-10 23:24 ` Fwd: " Nathan Scott
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Colin Watson @ 2013-10-10 13:38 UTC (permalink / raw)
To: submit
Package: xfsprogs
Version: 3.1.9
Severity: important
Tags: patch
User: debian-arm@lists.debian.org
Usertags: arm64
xfsprogs' config.guess/config.sub are out of date for the forthcoming
arm64 port. The attached patch sets things up so that you don't have to
be bothered by this type of bug for future ports.
* Use the autotools-dev dh addon to update config.guess/config.sub for
arm64.
diff -Nru xfsprogs-3.1.9/debian/control xfsprogs-3.1.9ubuntu1/debian/control
--- xfsprogs-3.1.9/debian/control 2012-12-12 23:21:22.000000000 +0000
+++ xfsprogs-3.1.9ubuntu1/debian/control 2013-10-10 14:25:31.000000000 +0100
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: XFS Development Team <xfs@oss.sgi.com>
Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>
-Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev | libreadline5-dev, libblkid-dev (>= 2.17), linux-libc-dev
+Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev | libreadline5-dev, libblkid-dev (>= 2.17), linux-libc-dev, autotools-dev
Standards-Version: 3.9.1
Homepage: http://oss.sgi.com/projects/xfs/
diff -Nru xfsprogs-3.1.9/debian/rules xfsprogs-3.1.9ubuntu1/debian/rules
--- xfsprogs-3.1.9/debian/rules 2010-08-18 04:53:43.000000000 +0100
+++ xfsprogs-3.1.9ubuntu1/debian/rules 2013-10-10 14:26:47.000000000 +0100
@@ -35,6 +35,7 @@
.census:
@echo "== dpkg-buildpackage: configure" 1>&2
$(checkdir)
+ dh_autotools-dev_updateconfig
$(options) $(MAKE) include/platform_defs.h
touch .census
@@ -57,6 +58,8 @@
$(MAKE) distclean
-rm -rf $(dirme) $(dirdev) $(dirdi)
-rm -f debian/*substvars debian/files* debian/*.debhelper
+ dh_autotools-dev_restoreconfig
+ dh_clean
binary-indep:
Thanks,
--
Colin Watson [cjwatson@ubuntu.com]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread* Fwd: Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
2013-10-10 13:38 Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64 Colin Watson
@ 2013-10-10 23:24 ` Nathan Scott
2013-10-10 23:56 ` Nathan Scott
2013-10-10 23:25 ` Nathan Scott
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Nathan Scott @ 2013-10-10 23:24 UTC (permalink / raw)
To: XFS
Hi all,
Have tested this out here & works just fine - please merge.
Signed-off-by: Nathan Scott <nathans@debian.org>
and tested-by, reviewed-by, etc ... whatever floats your boat.
thanks!
----- Forwarded Message -----
From: "Colin Watson" <cjwatson@ubuntu.com>
To: submit@bugs.debian.org
Sent: Friday, October 11, 2013 12:38:11 AM
Subject: Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
Package: xfsprogs
Version: 3.1.9
Severity: important
Tags: patch
User: debian-arm@lists.debian.org
Usertags: arm64
xfsprogs' config.guess/config.sub are out of date for the forthcoming
arm64 port. The attached patch sets things up so that you don't have to
be bothered by this type of bug for future ports.
* Use the autotools-dev dh addon to update config.guess/config.sub for
arm64.
diff -Nru xfsprogs-3.1.9/debian/control xfsprogs-3.1.9ubuntu1/debian/control
--- xfsprogs-3.1.9/debian/control 2012-12-12 23:21:22.000000000 +0000
+++ xfsprogs-3.1.9ubuntu1/debian/control 2013-10-10 14:25:31.000000000 +0100
@@ -3,7 +3,7 @@
Priority: optional
Maintainer: XFS Development Team <xfs@oss.sgi.com>
Uploaders: Nathan Scott <nathans@debian.org>, Anibal Monsalve Salazar <anibal@debian.org>
-Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev | libreadline5-dev, libblkid-dev (>= 2.17), linux-libc-dev
+Build-Depends: uuid-dev, autoconf, debhelper (>= 5), gettext, libtool, libreadline-gplv2-dev | libreadline5-dev, libblkid-dev (>= 2.17), linux-libc-dev, autotools-dev
Standards-Version: 3.9.1
Homepage: http://oss.sgi.com/projects/xfs/
diff -Nru xfsprogs-3.1.9/debian/rules xfsprogs-3.1.9ubuntu1/debian/rules
--- xfsprogs-3.1.9/debian/rules 2010-08-18 04:53:43.000000000 +0100
+++ xfsprogs-3.1.9ubuntu1/debian/rules 2013-10-10 14:26:47.000000000 +0100
@@ -35,6 +35,7 @@
.census:
@echo "== dpkg-buildpackage: configure" 1>&2
$(checkdir)
+ dh_autotools-dev_updateconfig
$(options) $(MAKE) include/platform_defs.h
touch .census
@@ -57,6 +58,8 @@
$(MAKE) distclean
-rm -rf $(dirme) $(dirdev) $(dirdi)
-rm -f debian/*substvars debian/files* debian/*.debhelper
+ dh_autotools-dev_restoreconfig
+ dh_clean
binary-indep:
Thanks,
--
Colin Watson [cjwatson@ubuntu.com]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
2013-10-10 23:24 ` Fwd: " Nathan Scott
@ 2013-10-10 23:56 ` Nathan Scott
2013-10-18 17:39 ` Rich Johnston
0 siblings, 1 reply; 9+ messages in thread
From: Nathan Scott @ 2013-10-10 23:56 UTC (permalink / raw)
To: XFS
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
----- Original Message -----
> ...
> Have tested this out here & works just fine - please merge.
>
Also, the attached fixes a warning in the deb build for me,
plus some trivial cleanup in the release script.
cheers.
--
Nathan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: xfsprogs-patchlet --]
[-- Type: text/x-patch; name=xfsprogs-patchlet, Size: 637 bytes --]
diff --git a/debian/changelog b/debian/changelog
index 125471d..0935e07 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -2,7 +2,7 @@ xfsprogs (3.1.11) unstable; urgency=low
* New upstream release
- -- Nathan Scott <nathans@debian.org> Wed, 08 May 2013 12:59:56 -0500
+ -- Nathan Scott <nathans@debian.org> Wed, 08 May 2013 12:59:56 -0500
xfsprogs (3.1.9) unstable; urgency=low
diff --git a/release.sh b/release.sh
index db5cc74..e209574 100755
--- a/release.sh
+++ b/release.sh
@@ -1,6 +1,6 @@
-#!/bin/bash
+#!/bin/sh
#
-# Automate generation a new release
+# Automate generation of a new release
#
. ./VERSION
[-- Attachment #3: Type: text/plain, Size: 121 bytes --]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
2013-10-10 23:56 ` Nathan Scott
@ 2013-10-18 17:39 ` Rich Johnston
0 siblings, 0 replies; 9+ messages in thread
From: Rich Johnston @ 2013-10-18 17:39 UTC (permalink / raw)
To: Nathan Scott, XFS
Please submit as a patch with a new subject next time ;)
commit 5b962abcbb952e5409e2b2a1ecbc71b5d370cdea
Author: Nathan Scott <nathans@debian.org>
Date: Thu Oct 10 23:56:19 2013 +0000
xfsprogs: fix a warning in the deb build
Fixes a warning in the deb build for me, plus some trivial cleanup
in the release script.
Signed-off-by: Nathan Scott <nathans@debian.com>
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
On 10/10/2013 06:56 PM, Nathan Scott wrote:
>
> ----- Original Message -----
>> ...
>> Have tested this out here & works just fine - please merge.
>>
>
> Also, the attached fixes a warning in the deb build for me,
> plus some trivial cleanup in the release script.
>
> cheers.
>
> --
> Nathan
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
2013-10-10 13:38 Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64 Colin Watson
2013-10-10 23:24 ` Fwd: " Nathan Scott
@ 2013-10-10 23:25 ` Nathan Scott
2013-10-15 19:42 ` Christoph Hellwig
2013-10-18 17:30 ` Rich Johnston
3 siblings, 0 replies; 9+ messages in thread
From: Nathan Scott @ 2013-10-10 23:25 UTC (permalink / raw)
To: Colin Watson, 725971
Hi Colin,
Looks good to me, thanks - will follow up & get this merged.
cheers.
--
Nathan
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
2013-10-10 13:38 Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64 Colin Watson
2013-10-10 23:24 ` Fwd: " Nathan Scott
2013-10-10 23:25 ` Nathan Scott
@ 2013-10-15 19:42 ` Christoph Hellwig
2013-10-15 21:24 ` Colin Watson
2013-10-18 17:30 ` Rich Johnston
3 siblings, 1 reply; 9+ messages in thread
From: Christoph Hellwig @ 2013-10-15 19:42 UTC (permalink / raw)
To: Colin Watson, 725971; +Cc: submit
While updating it in the debhelp is nice for the Debian package I'd also
really like to see a patch updating the files in the repository. Colin,
would you mind sending that patch, too?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
2013-10-15 19:42 ` Christoph Hellwig
@ 2013-10-15 21:24 ` Colin Watson
2013-10-15 21:29 ` Christoph Hellwig
0 siblings, 1 reply; 9+ messages in thread
From: Colin Watson @ 2013-10-15 21:24 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: 725971
On Tue, Oct 15, 2013 at 12:42:11PM -0700, Christoph Hellwig wrote:
> While updating it in the debhelp is nice for the Debian package I'd also
> really like to see a patch updating the files in the repository. Colin,
> would you mind sending that patch, too?
I looked, but there's nothing to send; the xfsprogs repository doesn't
contain those files. They're updated by the configure target in
Makefile, which is run as part of ./release.sh via "make dist". (Good;
this should be as automatic as possible.)
IOW, any new upstream release will contain updated files as long as the
developer who built the release has current libtool etc. installed. But
of course this should be fixed to auto-update at build time in the
Debian packaging anyway, since we want to be able to port to new
architectures without having to upload lots of new source packages or
take lots of new upstream releases at the same time; it makes life so
much easier.
Cheers,
--
Colin Watson [cjwatson@ubuntu.com]
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
2013-10-15 21:24 ` Colin Watson
@ 2013-10-15 21:29 ` Christoph Hellwig
0 siblings, 0 replies; 9+ messages in thread
From: Christoph Hellwig @ 2013-10-15 21:29 UTC (permalink / raw)
To: Colin Watson; +Cc: Christoph Hellwig, 725971
On Tue, Oct 15, 2013 at 10:24:48PM +0100, Colin Watson wrote:
> I looked, but there's nothing to send; the xfsprogs repository doesn't
> contain those files. They're updated by the configure target in
> Makefile, which is run as part of ./release.sh via "make dist". (Good;
> this should be as automatic as possible.)
Oh, forgot about that.
> IOW, any new upstream release will contain updated files as long as the
> developer who built the release has current libtool etc. installed. But
> of course this should be fixed to auto-update at build time in the
> Debian packaging anyway, since we want to be able to port to new
> architectures without having to upload lots of new source packages or
> take lots of new upstream releases at the same time; it makes life so
> much easier.
As said, I don't disagree with your patch at all, I was just asking for
an additional patch which turned out not to be nessecary.
Thanks a lot!
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64
2013-10-10 13:38 Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64 Colin Watson
` (2 preceding siblings ...)
2013-10-15 19:42 ` Christoph Hellwig
@ 2013-10-18 17:30 ` Rich Johnston
3 siblings, 0 replies; 9+ messages in thread
From: Rich Johnston @ 2013-10-18 17:30 UTC (permalink / raw)
To: Colin Watson, 725971, submit
This has been committed.
Thanks
--Rich
commit 773d6f6e3800dce5d27af687ebd3ff323dcdfd72
Author: Colin Watson <cjwatson@ubuntu.com>
Date: Thu Oct 17 15:27:02 2013 -0500
Sent: Friday, October 11, 2013 12:38:11 AM
Subject: Bug#725971: xfsprogs: config.guess/config.sub out of date
for arm64
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-10-18 17:39 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-10 13:38 Bug#725971: xfsprogs: config.guess/config.sub out of date for arm64 Colin Watson
2013-10-10 23:24 ` Fwd: " Nathan Scott
2013-10-10 23:56 ` Nathan Scott
2013-10-18 17:39 ` Rich Johnston
2013-10-10 23:25 ` Nathan Scott
2013-10-15 19:42 ` Christoph Hellwig
2013-10-15 21:24 ` Colin Watson
2013-10-15 21:29 ` Christoph Hellwig
2013-10-18 17:30 ` Rich Johnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox