* xfstests: Replace lstat64 with cat in test 120
@ 2012-08-22 18:54 Rich Johnston
2012-08-22 20:59 ` Alex Elder
0 siblings, 1 reply; 5+ messages in thread
From: Rich Johnston @ 2012-08-22 18:54 UTC (permalink / raw)
The later versions of libtool (i.e.2.4+) create a wrapper (bash script) for
lstat64 in the src directory. The wrapper calls the real binary created by
libtool (.libs/lstat64)
Test 120 only copies src/lstat64 to $SCRATCH_MNT. If a later version of
libtool is used then only the wrapper is copied to $SCRATCH_MNT and the wrapper
will fail to find .libs/lstat64.
~/xfstests # diff 120.out 120.out.bad
/mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist
This script is just a wrapper for lstat64.
See the libtool documentation for more information.
This patch copies /usr/bin/cat (which is readily availible on unix systems) to
$SCRATCH_MNT instead of src/lstat64.
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
---
120 | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: b/120
===================================================================
--- a/120
+++ b/120
@@ -68,12 +68,12 @@ fi
#executable file
echo "*** copying file ***"
-cp src/lstat64 $SCRATCH_MNT
-src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
+cp /bin/cat $SCRATCH_MNT
+src/lstat64 $SCRATCH_MNT/cat >$tmp.out
sleep 5
echo "*** executing file ***"
-$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
-_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
+$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
+_compare_access_times $SCRATCH_MNT/cat "executing file"
#reading file
echo "*** creating file ***"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xfstests: Replace lstat64 with cat in test 120
2012-08-22 18:54 xfstests: Replace lstat64 with cat in test 120 Rich Johnston
@ 2012-08-22 20:59 ` Alex Elder
2012-08-23 16:12 ` Rich Johnston
0 siblings, 1 reply; 5+ messages in thread
From: Alex Elder @ 2012-08-22 20:59 UTC (permalink / raw)
To: xfs
On 08/22/2012 01:54 PM, Rich Johnston wrote:
> The later versions of libtool (i.e.2.4+) create a wrapper (bash script) for
> lstat64 in the src directory. The wrapper calls the real binary created by
> libtool (.libs/lstat64)
>
> Test 120 only copies src/lstat64 to $SCRATCH_MNT. If a later version of
> libtool is used then only the wrapper is copied to $SCRATCH_MNT and the wrapper
> will fail to find .libs/lstat64.
>
> ~/xfstests # diff 120.out 120.out.bad
> /mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist
> This script is just a wrapper for lstat64.
> See the libtool documentation for more information.
>
> This patch copies /usr/bin/cat (which is readily availible on unix systems) to
> $SCRATCH_MNT instead of src/lstat64.
I was going to suggest you use /bin/cat instead, but it appears
the actual patch does.
Please update your description. Otherwise, looks good to me.
Reviewed-by: Alex Elder <elder@inktank.com>
>
> Signed-off-by: Rich Johnston <rjohnston@sgi.com>
>
> ---
> 120 | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Index: b/120
> ===================================================================
> --- a/120
> +++ b/120
> @@ -68,12 +68,12 @@ fi
>
> #executable file
> echo "*** copying file ***"
> -cp src/lstat64 $SCRATCH_MNT
> -src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
> +cp /bin/cat $SCRATCH_MNT
> +src/lstat64 $SCRATCH_MNT/cat >$tmp.out
> sleep 5
> echo "*** executing file ***"
> -$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
> -_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
> +$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
> +_compare_access_times $SCRATCH_MNT/cat "executing file"
>
> #reading file
> echo "*** creating file ***"
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: xfstests: Replace lstat64 with cat in test 120
2012-08-22 20:59 ` Alex Elder
@ 2012-08-23 16:12 ` Rich Johnston
0 siblings, 0 replies; 5+ messages in thread
From: Rich Johnston @ 2012-08-23 16:12 UTC (permalink / raw)
To: Alex Elder; +Cc: xfs
On 08/22/2012 03:59 PM, Alex Elder wrote:
> On 08/22/2012 01:54 PM, Rich Johnston wrote:
>> The later versions of libtool (i.e.2.4+) create a wrapper (bash script) for
>> lstat64 in the src directory. The wrapper calls the real binary created by
>> libtool (.libs/lstat64)
>>
>> Test 120 only copies src/lstat64 to $SCRATCH_MNT. If a later version of
>> libtool is used then only the wrapper is copied to $SCRATCH_MNT and the wrapper
>> will fail to find .libs/lstat64.
>>
>> ~/xfstests # diff 120.out 120.out.bad
>> /mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist
>> This script is just a wrapper for lstat64.
>> See the libtool documentation for more information.
>>
>> This patch copies /usr/bin/cat (which is readily availible on unix systems) to
>> $SCRATCH_MNT instead of src/lstat64.
>
> I was going to suggest you use /bin/cat instead, but it appears
> the actual patch does.
>
> Please update your description. Otherwise, looks good to me.
Thanks for the review Alex. Good catch, yes I will correct it when I
commit this patch along with a few Description corrections pointed out
by Dave C.
--Rich
>
> Reviewed-by: Alex Elder <elder@inktank.com>
>
>>
>> Signed-off-by: Rich Johnston <rjohnston@sgi.com>
>>
>> ---
>> 120 | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> Index: b/120
>> ===================================================================
>> --- a/120
>> +++ b/120
>> @@ -68,12 +68,12 @@ fi
>>
>> #executable file
>> echo "*** copying file ***"
>> -cp src/lstat64 $SCRATCH_MNT
>> -src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
>> +cp /bin/cat $SCRATCH_MNT
>> +src/lstat64 $SCRATCH_MNT/cat >$tmp.out
>> sleep 5
>> echo "*** executing file ***"
>> -$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
>> -_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
>> +$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
>> +_compare_access_times $SCRATCH_MNT/cat "executing file"
>>
>> #reading file
>> echo "*** creating file ***"
>>
>> _______________________________________________
>> xfs mailing list
>> xfs@oss.sgi.com
>> http://oss.sgi.com/mailman/listinfo/xfs
>>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <20120822190605.279843301@sgi.com>]
* xfstests: Replace lstat64 with cat in test 120
[not found] <20120822190605.279843301@sgi.com>
@ 2012-08-22 19:06 ` rjohnston
2012-08-22 19:06 ` rjohnston
1 sibling, 0 replies; 5+ messages in thread
From: rjohnston @ 2012-08-22 19:06 UTC (permalink / raw)
To: xfs
[-- Attachment #1: replace_lstat64_with_cat.patch --]
[-- Type: text/plain, Size: 1565 bytes --]
The later versions of libtool (i.e.2.4+) create a wrapper (bash script) for
lstat64 in the src directory. The wrapper calls the real binary created by
libtool (.libs/lstat64)
Test 120 only copies src/lstat64 to $SCRATCH_MNT. If a later version of
libtool is used then only the wrapper is copied to $SCRATCH_MNT and the wrapper
will fail to find .libs/lstat64.
~/xfstests # diff 120.out 120.out.bad
/mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist
This script is just a wrapper for lstat64.
See the libtool documentation for more information.
This patch copies /usr/bin/cat (which is readily availible on unix systems) to
$SCRATCH_MNT instead of src/lstat64.
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
---
120 | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: b/120
===================================================================
--- a/120
+++ b/120
@@ -68,12 +68,12 @@ fi
#executable file
echo "*** copying file ***"
-cp src/lstat64 $SCRATCH_MNT
-src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
+cp /bin/cat $SCRATCH_MNT
+src/lstat64 $SCRATCH_MNT/cat >$tmp.out
sleep 5
echo "*** executing file ***"
-$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
-_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
+$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
+_compare_access_times $SCRATCH_MNT/cat "executing file"
#reading file
echo "*** creating file ***"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread* xfstests: Replace lstat64 with cat in test 120
[not found] <20120822190605.279843301@sgi.com>
2012-08-22 19:06 ` rjohnston
@ 2012-08-22 19:06 ` rjohnston
1 sibling, 0 replies; 5+ messages in thread
From: rjohnston @ 2012-08-22 19:06 UTC (permalink / raw)
To: xfs
[-- Attachment #1: replace_lstat64_with_cat.patch --]
[-- Type: text/plain, Size: 1565 bytes --]
The later versions of libtool (i.e.2.4+) create a wrapper (bash script) for
lstat64 in the src directory. The wrapper calls the real binary created by
libtool (.libs/lstat64)
Test 120 only copies src/lstat64 to $SCRATCH_MNT. If a later version of
libtool is used then only the wrapper is copied to $SCRATCH_MNT and the wrapper
will fail to find .libs/lstat64.
~/xfstests # diff 120.out 120.out.bad
/mnt/scratch/lstat64: error: `/mnt/scratch/.libs/lstat64' does not exist
This script is just a wrapper for lstat64.
See the libtool documentation for more information.
This patch copies /usr/bin/cat (which is readily availible on unix systems) to
$SCRATCH_MNT instead of src/lstat64.
Signed-off-by: Rich Johnston <rjohnston@sgi.com>
---
120 | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: b/120
===================================================================
--- a/120
+++ b/120
@@ -68,12 +68,12 @@ fi
#executable file
echo "*** copying file ***"
-cp src/lstat64 $SCRATCH_MNT
-src/lstat64 $SCRATCH_MNT/lstat64 >$tmp.out
+cp /bin/cat $SCRATCH_MNT
+src/lstat64 $SCRATCH_MNT/cat >$tmp.out
sleep 5
echo "*** executing file ***"
-$SCRATCH_MNT/lstat64 $SCRATCH_MNT/lstat64 >/dev/null
-_compare_access_times $SCRATCH_MNT/lstat64 "executing file"
+$SCRATCH_MNT/cat $SCRATCH_MNT/cat >/dev/null
+_compare_access_times $SCRATCH_MNT/cat "executing file"
#reading file
echo "*** creating file ***"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-08-23 16:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-22 18:54 xfstests: Replace lstat64 with cat in test 120 Rich Johnston
2012-08-22 20:59 ` Alex Elder
2012-08-23 16:12 ` Rich Johnston
[not found] <20120822190605.279843301@sgi.com>
2012-08-22 19:06 ` rjohnston
2012-08-22 19:06 ` rjohnston
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox