Re: [PATCH] xfs: stop the sync worker before xfs_unmountfs

Mark Tinguely
2012-09-18T13:27:00Z

On 09/13/12 16:18, Ben Myers wrote:
> Cancel work of the xfs_sync_worker before teardown of the log in
> xfs_unmountfs. This prevents occasional crashes on unmount like so:
...
> Signed-off-by: Ben Myers<bpm@sgi.com>
>
> Index: xfs/fs/xfs/xfs_super.c
> ===================================================================
> --- xfs.orig/fs/xfs/xfs_super.c
> +++ xfs/fs/xfs/xfs_super.c
> @@ -919,6 +919,7 @@ xfs_fs_put_super(
> struct xfs_mount *mp = XFS_M(sb);
>
> xfs_filestream_unmount(mp);
> + cancel_delayed_work_sync(&mp->m_sync_work);
> xfs_unmountfs(mp);
> xfs_syncd_stop(mp);
> xfs_freesb(mp);
>

Tests successfully on all 3 of the machines that were crashing without
the patch.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>