From: Brian Foster <bfoster@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC PATCH 4/4] xfs: add background scanning to clear EOFBLOCKS inodes
Date: Tue, 04 Sep 2012 10:10:57 -0400 [thread overview]
Message-ID: <50460BF1.3070100@redhat.com> (raw)
In-Reply-To: <20120903052842.GT15292@dastard>
On 09/03/2012 01:28 AM, Dave Chinner wrote:
> On Mon, Aug 27, 2012 at 03:51:51PM -0400, Brian Foster wrote:
>> Create a delayed_work to enable background scanning and freeing
>> of EOFBLOCKS inodes. The scanner kicks in once speculative
>> preallocation occurs and stops requeueing itself when no EOFBLOCKS
>> inodes exist.
>>
>> Scans are queued on the existing syncd workqueue and the interval
>> is tied to the syncd interval, which is a default of 30s. The
>> minimum file size for a background scan is hardcoded to 100MB.
>
> I'd set it to be much longer than the xfs_syncd_centisecs period.
> The data may not be written back for a long while, and a file that
> is open, written and closed repeatedly (NFS write patterns for large
> and/or slowly written files) should not have it's preallocation
> truncated every 30s.
>
> I'd suggest that a 5 minute sweep is probably sufficiently frequent
> to avoid most fragmentation issues and long term buildup of speculative
> preallocation whilst not perturbing large/slow writers too much....
>
Any thoughts on having tunables for both values (time and min size?) on
the background scanning?
> Apart from that, there isn't anything wrong with the code, except
> I'll note again that it conflicts with my syncd removal patchset....
>
Yeah, I skimmed through those patches and noticed it would shuffle this
code around. Thanks for pointing it out. I'll keep an eye on that set.
Thanks for the review. I'll follow up with a patchset that incorporates
the feedback.
Brian
> Cheers,
>
> Dave.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-04 14:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-27 19:51 [RFC PATCH 0/4] xfs: add support for tracking inodes with post-EOF speculative preallocation Brian Foster
2012-08-27 19:51 ` [RFC PATCH 1/4] xfs: add EOFBLOCKS inode tagging/untagging Brian Foster
2012-09-03 4:20 ` Dave Chinner
2012-08-27 19:51 ` [RFC PATCH 2/4] xfs: create function to scan and clear EOFBLOCKS inodes Brian Foster
2012-09-03 5:06 ` Dave Chinner
2012-09-04 14:10 ` Brian Foster
2012-09-05 6:42 ` Dave Chinner
2012-09-05 12:22 ` Brian Foster
2012-08-27 19:51 ` [RFC PATCH 3/4] xfs: add FREE_EOFBLOCKS ioctl Brian Foster
2012-09-03 5:17 ` Dave Chinner
2012-09-04 14:10 ` Brian Foster
2012-09-05 6:49 ` Dave Chinner
2012-09-05 12:22 ` Brian Foster
2012-08-27 19:51 ` [RFC PATCH 4/4] xfs: add background scanning to clear EOFBLOCKS inodes Brian Foster
2012-09-03 5:28 ` Dave Chinner
2012-09-04 14:10 ` Brian Foster [this message]
2012-09-05 7:00 ` Dave Chinner
2012-09-05 12:22 ` Brian Foster
2012-09-05 23:43 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50460BF1.3070100@redhat.com \
--to=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox