From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q84Km55J158796 for ; Tue, 4 Sep 2012 15:48:05 -0500 Message-ID: <5046693A.9010102@sgi.com> Date: Tue, 04 Sep 2012 15:48:58 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 07/13] xfs: xfs_sync_data is redundant. References: <1346328017-2795-1-git-send-email-david@fromorbit.com> <1346328017-2795-8-git-send-email-david@fromorbit.com> In-Reply-To: <1346328017-2795-8-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 08/30/12 07:00, Dave Chinner wrote: > From: Dave Chinner > > We don't do any data writeback from XFS any more - the VFS is > completely responsible for that, including for freeze. We can > replace the remaining caller with the VFS level function that > achieves the same thing, but without conflicting with current > writeback work - writeback_inodes_sb_if_idle(). > > This means we can remove the flush_work and xfs_flush_inodes() - the > VFS functionality completely replaces the internal flush queue for > doing this writeback work in a separate context to avoid stack > overruns.. > > Signed-off-by: Dave Chinner > --- I get a XFS hang on xfstest 205 - couple different machines: # cat /proc/413/stack [] sleep_on_page+0x9/0x10 [] __lock_page+0x64/0x70 [] write_cache_pages+0x368/0x510 [] generic_writepages+0x4c/0x70 [] xfs_vm_writepages+0x54/0x70 [xfs] [] do_writepages+0x1b/0x40 [] __writeback_single_inode+0x45/0x160 [] writeback_sb_inodes+0x2a7/0x490 [] wb_writeback+0x119/0x2b0 [] wb_do_writeback+0xd4/0x230 [] bdi_writeback_thread+0xdb/0x230 [] kthread+0x9e/0xb0 [] kernel_thread_helper+0x4/0x10 [] 0xffffffffffffffff # cat /proc/12489/stack (dd command) [] writeback_inodes_sb_nr+0x85/0xb0 [] writeback_inodes_sb+0x5c/0x80 [] writeback_inodes_sb_if_idle+0x42/0x60 [] xfs_iomap_write_delay+0x28e/0x320 [xfs] [] __xfs_get_blocks+0x2b8/0x500 [xfs] [] xfs_get_blocks+0xc/0x10 [xfs] [] __block_write_begin+0x2af/0x5c0 [] xfs_vm_write_begin+0x61/0xd0 [xfs] [] generic_perform_write+0xc2/0x1e0 [] generic_file_buffered_write+0x60/0xa0 [] xfs_file_buffered_aio_write+0x11d/0x1b0 [xfs] [] xfs_file_aio_write+0x110/0x170 [xfs] [] do_sync_write+0xa1/0xf0 [] vfs_write+0xcb/0x130 [] sys_write+0x50/0x90 [] system_call_fastpath+0x16/0x1b [] 0xffffffffffffffff _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs