From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q84L6uZa162201 for ; Tue, 4 Sep 2012 16:06:56 -0500 Message-ID: <50466DA8.2020802@sgi.com> Date: Tue, 04 Sep 2012 16:07:52 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 12/13] xfs: move inode locking functions to xfs_inode.c References: <1346328017-2795-1-git-send-email-david@fromorbit.com> <1346328017-2795-13-git-send-email-david@fromorbit.com> In-Reply-To: <1346328017-2795-13-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 08/30/12 07:00, Dave Chinner wrote: > From: Dave Chinner > > xfs_ilock() and friends really aren't related to the inode cache in > any way, so move them to xfs_inode.c with all the other inode > related functionality. > > While doing this move, move the xfs_ilock() tracepoints to *before* > the lock is taken so that when a hang on a lock occurs we have > events to indicate which process and what inode we were trying to > lock when the hang occurred. This is much better than the current > silence we get on a hang... > > Signed-off-by: Dave Chinner > --- Looks good. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs