From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q8BLOksa156852 for ; Tue, 11 Sep 2012 16:24:46 -0500 Message-ID: <504FAC55.1000508@sgi.com> Date: Tue, 11 Sep 2012 16:25:41 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 03/13] xfs: rationalise xfs_mount_wq users References: <1346328017-2795-1-git-send-email-david@fromorbit.com> <1346328017-2795-4-git-send-email-david@fromorbit.com> In-Reply-To: <1346328017-2795-4-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On 08/30/12 07:00, Dave Chinner wrote: > From: Dave Chinner > > Instead of starting and stopping background work on the xfs_mount_wq > all at the same time, separate them to where they really are needed > to start and stop. > > The xfs_sync_worker, only needs to be started after all the mount > processing has completed successfully, while it needs to be stopped > before the log is unmounted. > > The xfs_reclaim_worker is started on demand, and can be > stopped before the unmount process does it's own inode reclaim pass. > > The xfs_flush_inodes work is run on demand, and so we really only > need to ensure that it has stopped running before we start > processing an unmount, freeze or remount,ro. > > Signed-off-by: Dave Chinner > --- The patch itself looks good. and the "atomic_read(&bp->b_hold)> 0" assert appears specific to my machines, so forgive the noise. Reviewed-by: Mark Tinguely _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs