From: Mark Tinguely <tinguely@sgi.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] libxcmd: link against readline
Date: Thu, 13 Sep 2012 10:30:07 -0500 [thread overview]
Message-ID: <5051FBFF.5080507@sgi.com> (raw)
In-Reply-To: <1345936050-15139-1-git-send-email-vapier@gentoo.org>
On 08/25/12 18:07, Mike Frysinger wrote:
> This library uses readline funcs (the input.c file), so we need to link
> this shared library against it.
>
> URL: https://bugs.gentoo.org/432644
> Reported-by: David Badia<dbadia@gmail.com>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
> libxcmd/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libxcmd/Makefile b/libxcmd/Makefile
> index b3544f4..ce082a5 100644
> --- a/libxcmd/Makefile
> +++ b/libxcmd/Makefile
> @@ -22,10 +22,12 @@ endif
>
> ifeq ($(ENABLE_READLINE),yes)
> LCFLAGS += -DENABLE_READLINE
> +LTLIBS += $(LIBREADLINE) $(LIBTERMCAP)
> endif
>
> ifeq ($(ENABLE_EDITLINE),yes)
> LCFLAGS += -DENABLE_EDITLINE
> +LTLIBS += $(LIBEDITLINE) $(LIBTERMCAP)
> endif
>
> default: ltdepend $(LTLIBRARY)
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-13 15:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-25 23:07 [PATCH] libxcmd: link against readline Mike Frysinger
2012-09-13 15:30 ` Mark Tinguely [this message]
2012-09-24 21:55 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5051FBFF.5080507@sgi.com \
--to=tinguely@sgi.com \
--cc=vapier@gentoo.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox