From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q8DKBOZT211901 for ; Thu, 13 Sep 2012 15:11:24 -0500 Message-ID: <50523E20.5000508@sgi.com> Date: Thu, 13 Sep 2012 15:12:16 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 020/102] xfs: warn if direct reclaim tries to writeback pages References: <1345698180-13612-1-git-send-email-david@fromorbit.com> <1345698180-13612-21-git-send-email-david@fromorbit.com> <20120827181742.GA13970@infradead.org> <20120905113242.GL11266@suse.de> In-Reply-To: <20120905113242.GL11266@suse.de> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Mel Gorman Cc: Christoph Hellwig , xfs@oss.sgi.com On 09/05/12 06:32, Mel Gorman wrote: > On Mon, Aug 27, 2012 at 02:17:42PM -0400, Christoph Hellwig wrote: >> On Thu, Aug 23, 2012 at 03:01:38PM +1000, Dave Chinner wrote: >>> From: Mel Gorman >>> >>> Upstream commit: 94054fa3fca1fd78db02cb3d68d5627120f0a1d4 >>> >>> Direct reclaim should never writeback pages. For now, handle the >>> situation and warn about it. Ultimately, this will be a BUG_ON. >> >> Is this actually the case on 3.0-stable? >> > > No, it is not. AFAIK, 3.0-stable does not contain [ee72886d: mm: vmscan: > do not writeback filesystem pages in direct reclaim] which is the absolute > minimum required for commit [94054fa3: xfs: warn if direct reclaim tries > to writeback pages] to make sense. > I hit this warning testing on a linux-30.42 with a x86_64. WARNING: at fs/xfs/linux-2.6/xfs_aops.c:961 xfs_vm_writepage+0x63c/0x6a0() Hardware name: S2721-533 Thunder i7501 Pro Modules linked in: ext4 jbd2 crc16 Pid: 12122, comm: cp Not tainted 3.0.42 #2 Call Trace: [] ? printk+0x18/0x1a [] warn_slowpath_common+0x6d/0xa0 [] ? xfs_vm_writepage+0x63c/0x6a0 [] ? xfs_vm_writepage+0x63c/0x6a0 [] warn_slowpath_null+0x1d/0x20 [] xfs_vm_writepage+0x63c/0x6a0 [] ? call_rcu_sched+0xd/0x10 [] ? radix_tree_delete+0x1cc/0x280 [] ? free_buffer_head+0x23/0x30 [] ? try_to_free_buffers+0x5a/0x90 [] shrink_page_list+0x542/0x750 [] ? __mod_zone_page_state+0x54/0x60 [] shrink_inactive_list+0x190/0x360 [] shrink_zone+0x410/0x580 [] do_try_to_free_pages+0x100/0x360 [] try_to_free_pages+0x89/0x120 [] __alloc_pages_nodemask+0x3eb/0x650 [] new_slab+0x4c/0x1a0 [] __slab_alloc.constprop.65+0xed/0x1d5 [] ? getname_flags+0x26/0x150 [] kmem_cache_alloc+0x11b/0x130 [] ? tick_dev_program_event+0x3f/0x160 [] ? getname_flags+0x26/0x150 [] getname_flags+0x26/0x150 [] ? tick_program_event+0x1c/0x30 [] user_path_at_empty+0x1f/0x80 [] ? rcu_irq_exit+0x8/0x10 [] ? irq_exit+0x37/0x90 [] ? smp_apic_timer_interrupt+0x54/0x90 [] user_path_at+0x1a/0x20 [] vfs_fstatat+0x4e/0x80 [] vfs_lstat+0x1b/0x20 [] sys_lstat64+0x11/0x30 [] ? filp_close+0x4f/0x70 [] ? sys_close+0x57/0xa0 [] syscall_call+0x7/0xb _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs