[PATCH] xfstests: 275, Don't remove all the files in SCRATCH_MNT.

[PATCH] xfstests: 275, Don't remove all the files in SCRATCH_MNT.

[Tao Ma]

From: Tao Ma <boyu.mt@taobao.com>

After the volume is mkfsed, it should have no other files that
need to be rmed. And what's more, it makes ext4 complain since
lost+found is also removed.

So remove this useless "rm -rf $SCRATCH_MNT/*".

Cc: Eric Sandeen <sandeen@sandeen.net>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
 275 |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/275 b/275
index 69b2895..06db775 100755
--- a/275
+++ b/275
@@ -57,8 +57,6 @@ umount $SCRATCH_DEV 2>/dev/null
 _scratch_mkfs_sized $((2 * 1024 * 1024 * 1024)) >>$seq.full 2>&1
 _scratch_mount
 
-rm -rf $SCRATCH_MNT/*
-
 dd if=/dev/zero of=$SCRATCH_MNT/tmp1 bs=256K count=1 >>$seq.full 2>&1
 [ $? -ne 0 ] && _fail "Error creating file"
 
-- 
1.7.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: 275, Don't remove all the files in SCRATCH_MNT.

[Eric Sandeen]

On 9/14/12 6:03 AM, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> After the volume is mkfsed, it should have no other files that
> need to be rmed. And what's more, it makes ext4 complain since
> lost+found is also removed.
> 
> So remove this useless "rm -rf $SCRATCH_MNT/*".

Oh, sigh, after all the review how did I miss that :/

Reviewed-by: Eric Sandeen <sandeen@sandeen.net>

SGI: I won't be pushing this to kernel.org trees per the emails yesterday.

Thanks,
-Eric

> Cc: Eric Sandeen <sandeen@sandeen.net>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>
> ---
>  275 |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/275 b/275
> index 69b2895..06db775 100755
> --- a/275
> +++ b/275
> @@ -57,8 +57,6 @@ umount $SCRATCH_DEV 2>/dev/null
>  _scratch_mkfs_sized $((2 * 1024 * 1024 * 1024)) >>$seq.full 2>&1
>  _scratch_mount
>  
> -rm -rf $SCRATCH_MNT/*
> -
>  dd if=/dev/zero of=$SCRATCH_MNT/tmp1 bs=256K count=1 >>$seq.full 2>&1
>  [ $? -ne 0 ] && _fail "Error creating file"
>  
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: 275, Don't remove all the files in SCRATCH_MNT.

[Ben Myers]

On Fri, Sep 14, 2012 at 07:03:12PM +0800, Tao Ma wrote:
> From: Tao Ma <boyu.mt@taobao.com>
> 
> After the volume is mkfsed, it should have no other files that
> need to be rmed. And what's more, it makes ext4 complain since
> lost+found is also removed.
> 
> So remove this useless "rm -rf $SCRATCH_MNT/*".
> 
> Cc: Eric Sandeen <sandeen@sandeen.net>
> Signed-off-by: Tao Ma <boyu.mt@taobao.com>

Committed to git://oss.sgi.com/xfs/cmds/xfstests.git, master branch.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs