* [PATCH] xfstests: fix a compile warning at seek_sanity_test.c
@ 2012-06-02 14:33 Jeff Liu
2012-09-19 13:36 ` Mark Tinguely
2012-09-24 21:21 ` Mark Tinguely
0 siblings, 2 replies; 6+ messages in thread
From: Jeff Liu @ 2012-06-02 14:33 UTC (permalink / raw)
To: xfs
Hello,
Compiler report warning at seek_sanity_test.c:
seek_sanity_test.c:46:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'int'
Below patch can fix it.
Signed-off-by: Jie Liu <jeff.liu@oracle.com>
---
src/seek_sanity_test.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
index a185e54..34f5508 100644
--- a/src/seek_sanity_test.c
+++ b/src/seek_sanity_test.c
@@ -42,8 +42,10 @@ static void get_file_system(int fd)
{
struct statfs buf;
- if (!fstatfs(fd, &buf))
- fprintf(stdout, "File system magic#: 0x%lx\n", buf.f_type);
+ if (!fstatfs(fd, &buf)) {
+ fprintf(stdout, "File system magic#: 0x%lx\n",
+ (unsigned long int)buf.f_type);
+ }
}
static int get_io_sizes(int fd)
--
1.7.9
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xfstests: fix a compile warning at seek_sanity_test.c
2012-06-02 14:33 [PATCH] xfstests: fix a compile warning at seek_sanity_test.c Jeff Liu
@ 2012-09-19 13:36 ` Mark Tinguely
2012-09-19 14:04 ` Jeff Liu
2012-09-24 21:21 ` Mark Tinguely
1 sibling, 1 reply; 6+ messages in thread
From: Mark Tinguely @ 2012-09-19 13:36 UTC (permalink / raw)
To: jeff.liu; +Cc: xfs
On 06/02/12 09:33, Jeff Liu wrote:
> Hello,
>
> Compiler report warning at seek_sanity_test.c:
> seek_sanity_test.c:46:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'int'
>
> Below patch can fix it.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
Sorry, looks like this clean-up patch has not been committed yet.
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: fix a compile warning at seek_sanity_test.c
2012-09-19 13:36 ` Mark Tinguely
@ 2012-09-19 14:04 ` Jeff Liu
2012-09-19 14:11 ` Mark Tinguely
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Liu @ 2012-09-19 14:04 UTC (permalink / raw)
To: Mark Tinguely; +Cc: xfs
On 09/19/2012 09:36 PM, Mark Tinguely wrote:
> On 06/02/12 09:33, Jeff Liu wrote:
>> Hello,
>>
>> Compiler report warning at seek_sanity_test.c:
>> seek_sanity_test.c:46:3: warning: format '%lx' expects type 'long
>> unsigned int', but argument 3 has type 'int'
>>
>> Below patch can fix it.
>>
>> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>
> Sorry, looks like this clean-up patch has not been committed yet.
>
> Looks good.
>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Could you please also consider another patch for 286 improvements at:
http://patchwork.xfs.org/patch/3731
Thanks,
-Jeff
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: fix a compile warning at seek_sanity_test.c
2012-09-19 14:04 ` Jeff Liu
@ 2012-09-19 14:11 ` Mark Tinguely
2012-09-19 14:17 ` Jeff Liu
0 siblings, 1 reply; 6+ messages in thread
From: Mark Tinguely @ 2012-09-19 14:11 UTC (permalink / raw)
To: jeff.liu; +Cc: xfs
On 09/19/12 09:04, Jeff Liu wrote:
> On 09/19/2012 09:36 PM, Mark Tinguely wrote:
>
>> On 06/02/12 09:33, Jeff Liu wrote:
>>> Hello,
>>>
>>> Compiler report warning at seek_sanity_test.c:
>>> seek_sanity_test.c:46:3: warning: format '%lx' expects type 'long
>>> unsigned int', but argument 3 has type 'int'
>>>
>>> Below patch can fix it.
>>>
>>> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>>
>> Sorry, looks like this clean-up patch has not been committed yet.
>>
>> Looks good.
>>
>> Reviewed-by: Mark Tinguely<tinguely@sgi.com>
>
>
> Could you please also consider another patch for 286 improvements at:
> http://patchwork.xfs.org/patch/3731
>
> Thanks,
> -Jeff
>
Yes, I will make sure it gets committed; it has been already reviewed.
Did I remember correctly that there is plans for another test for the
latest kernel features?
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: fix a compile warning at seek_sanity_test.c
2012-09-19 14:11 ` Mark Tinguely
@ 2012-09-19 14:17 ` Jeff Liu
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Liu @ 2012-09-19 14:17 UTC (permalink / raw)
To: Mark Tinguely; +Cc: xfs
On 09/19/2012 10:11 PM, Mark Tinguely wrote:
> On 09/19/12 09:04, Jeff Liu wrote:
>> On 09/19/2012 09:36 PM, Mark Tinguely wrote:
>>
>>> On 06/02/12 09:33, Jeff Liu wrote:
>>>> Hello,
>>>>
>>>> Compiler report warning at seek_sanity_test.c:
>>>> seek_sanity_test.c:46:3: warning: format '%lx' expects type 'long
>>>> unsigned int', but argument 3 has type 'int'
>>>>
>>>> Below patch can fix it.
>>>>
>>>> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>>>
>>> Sorry, looks like this clean-up patch has not been committed yet.
>>>
>>> Looks good.
>>>
>>> Reviewed-by: Mark Tinguely<tinguely@sgi.com>
>>
>>
>> Could you please also consider another patch for 286 improvements at:
>> http://patchwork.xfs.org/patch/3731
>>
>> Thanks,
>> -Jeff
>>
>
> Yes, I will make sure it gets committed; it has been already reviewed.
>
> Did I remember correctly that there is plans for another test for the
> latest kernel features?
Yes, we have discussed that before, however, I thought it was your idea
so I have not work it out. :)
I'll write if you have no time to do it.
-Jeff
>
> --Mark.
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests: fix a compile warning at seek_sanity_test.c
2012-06-02 14:33 [PATCH] xfstests: fix a compile warning at seek_sanity_test.c Jeff Liu
2012-09-19 13:36 ` Mark Tinguely
@ 2012-09-24 21:21 ` Mark Tinguely
1 sibling, 0 replies; 6+ messages in thread
From: Mark Tinguely @ 2012-09-24 21:21 UTC (permalink / raw)
To: jeff.liu; +Cc: xfs
On 06/02/12 09:33, Jeff Liu wrote:
> Hello,
>
> Compiler report warning at seek_sanity_test.c:
> seek_sanity_test.c:46:3: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'int'
>
> Below patch can fix it.
>
> Signed-off-by: Jie Liu<jeff.liu@oracle.com>
>
> ---
Committed to git://oss.sgi.com/xfs/cmds/xfstests.git, master branch.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-09-24 21:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-02 14:33 [PATCH] xfstests: fix a compile warning at seek_sanity_test.c Jeff Liu
2012-09-19 13:36 ` Mark Tinguely
2012-09-19 14:04 ` Jeff Liu
2012-09-19 14:11 ` Mark Tinguely
2012-09-19 14:17 ` Jeff Liu
2012-09-24 21:21 ` Mark Tinguely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox