From: Eric Sandeen <sandeen@redhat.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: add _require_freeze and minor cleanups
Date: Fri, 21 Sep 2012 15:20:45 -0500 [thread overview]
Message-ID: <505CCC1D.4000203@redhat.com> (raw)
In-Reply-To: <20120921195921.GB1140@sgi.com>
On 9/21/12 2:59 PM, Ben Myers wrote:
> On Fri, Sep 21, 2012 at 11:47:49AM -0500, Eric Sandeen wrote:
>> On 9/21/12 11:38 AM, Ben Myers wrote:
>>> Hey Eric,
>>>
...
>>> Pretty good idea to generalize _require_freeze. It looks like xfs_freeze is a
>>> script that uses xfs_io which uses xfsctl XFS_IOC_FREEZE. So isn't what you
>>> have here xfs specific? It wouldn't work for the other filesystems that
>>> implement s_op.freeze_fs:
>>
>> It got elevated to a generic ioctl:
>>
>> fs/xfs/xfs_fs.h:
>> /* XFS_IOC_FREEZE -- FIFREEZE 119 */
>> /* XFS_IOC_THAW -- FITHAW 120 */
>>
>> to:
>>
>> include/linux/fs.h:
>> #define FIFREEZE _IOWR('X', 119, int) /* Freeze */
>> #define FITHAW _IOWR('X', 120, int) /* Thaw */
>
> Ah, great. I see it now. It looks like test 119 is also using freeze. Should
> that one also _require_freeze?
Since it's xfs-specific, I didn't think it was necessary, but it could.
-Eric
> Reviewed-by: Ben Myers <bpm@sgi.com>
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-09-21 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 22:53 [PATCH] xfstests: add _require_freeze and minor cleanups Eric Sandeen
2012-09-21 16:38 ` Ben Myers
2012-09-21 16:47 ` Eric Sandeen
2012-09-21 19:59 ` Ben Myers
2012-09-21 20:20 ` Eric Sandeen [this message]
2012-09-25 9:33 ` Christoph Hellwig
2012-09-25 15:28 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505CCC1D.4000203@redhat.com \
--to=sandeen@redhat.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox