* [PATCH] libxcmd: link against readline
@ 2012-08-25 23:07 Mike Frysinger
2012-09-13 15:30 ` Mark Tinguely
2012-09-24 21:55 ` Mark Tinguely
0 siblings, 2 replies; 3+ messages in thread
From: Mike Frysinger @ 2012-08-25 23:07 UTC (permalink / raw)
To: xfs
This library uses readline funcs (the input.c file), so we need to link
this shared library against it.
URL: https://bugs.gentoo.org/432644
Reported-by: David Badia <dbadia@gmail.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
libxcmd/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libxcmd/Makefile b/libxcmd/Makefile
index b3544f4..ce082a5 100644
--- a/libxcmd/Makefile
+++ b/libxcmd/Makefile
@@ -22,10 +22,12 @@ endif
ifeq ($(ENABLE_READLINE),yes)
LCFLAGS += -DENABLE_READLINE
+LTLIBS += $(LIBREADLINE) $(LIBTERMCAP)
endif
ifeq ($(ENABLE_EDITLINE),yes)
LCFLAGS += -DENABLE_EDITLINE
+LTLIBS += $(LIBEDITLINE) $(LIBTERMCAP)
endif
default: ltdepend $(LTLIBRARY)
--
1.7.9.7
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libxcmd: link against readline
2012-08-25 23:07 [PATCH] libxcmd: link against readline Mike Frysinger
@ 2012-09-13 15:30 ` Mark Tinguely
2012-09-24 21:55 ` Mark Tinguely
1 sibling, 0 replies; 3+ messages in thread
From: Mark Tinguely @ 2012-09-13 15:30 UTC (permalink / raw)
To: Mike Frysinger; +Cc: xfs
On 08/25/12 18:07, Mike Frysinger wrote:
> This library uses readline funcs (the input.c file), so we need to link
> this shared library against it.
>
> URL: https://bugs.gentoo.org/432644
> Reported-by: David Badia<dbadia@gmail.com>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> ---
> libxcmd/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libxcmd/Makefile b/libxcmd/Makefile
> index b3544f4..ce082a5 100644
> --- a/libxcmd/Makefile
> +++ b/libxcmd/Makefile
> @@ -22,10 +22,12 @@ endif
>
> ifeq ($(ENABLE_READLINE),yes)
> LCFLAGS += -DENABLE_READLINE
> +LTLIBS += $(LIBREADLINE) $(LIBTERMCAP)
> endif
>
> ifeq ($(ENABLE_EDITLINE),yes)
> LCFLAGS += -DENABLE_EDITLINE
> +LTLIBS += $(LIBEDITLINE) $(LIBTERMCAP)
> endif
>
> default: ltdepend $(LTLIBRARY)
Looks good.
Reviewed-by: Mark Tinguely <tinguely@sgi.com>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libxcmd: link against readline
2012-08-25 23:07 [PATCH] libxcmd: link against readline Mike Frysinger
2012-09-13 15:30 ` Mark Tinguely
@ 2012-09-24 21:55 ` Mark Tinguely
1 sibling, 0 replies; 3+ messages in thread
From: Mark Tinguely @ 2012-09-24 21:55 UTC (permalink / raw)
To: Mike Frysinger; +Cc: xfs
On 08/25/12 18:07, Mike Frysinger wrote:
> This library uses readline funcs (the input.c file), so we need to link
> this shared library against it.
>
> URL: https://bugs.gentoo.org/432644
> Reported-by: David Badia<dbadia@gmail.com>
> Signed-off-by: Mike Frysinger<vapier@gentoo.org>
> Reviewed-by: Mark Tinguely <tinguely@sgi.com>
Committed to git://oss.sgi.com/xfs/cmds/xfsprogs.git master branch.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-09-24 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-25 23:07 [PATCH] libxcmd: link against readline Mike Frysinger
2012-09-13 15:30 ` Mark Tinguely
2012-09-24 21:55 ` Mark Tinguely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox