From: Eric Sandeen <sandeen@redhat.com>
To: xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfstests 068: Add mmap load
Date: Thu, 27 Sep 2012 22:33:45 -0500 [thread overview]
Message-ID: <50651A99.1070307@redhat.com> (raw)
Test 068 is the go-to test for freeze deadlock coverage;
unfortunately it only uses fsstress, which doesn't do any mmap
IO.
Using the existing fstest binary gets us a cheap mmap exerciser
as well.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I think it's fair to modify this test vs. making a new one -
it's never passed yet, and will only start passing in kernel 3.6,
so it shouldn't cause new test regressions to add mmap ops.
And I can verify that this finds mmap bugs; I had a backport
which messed up ext4's freeze vs. mmap handling, and this exposes
it. :)
diff --git a/068 b/068
index 617420c..a0bf425 100755
--- a/068
+++ b/068
@@ -90,6 +90,21 @@ touch $tmp.running
rmdir $STRESS_DIR
} &
+# start fstest -m loop in a background block; this gets us mmap coverage
+{
+ FSTEST_DIR="$SCRATCH_MNT/fstest_test_dir"
+ mkdir "$FSTEST_DIR"
+
+ procs=2
+ while [ -f "$tmp.running" ]
+ do
+ src/fstest -m -p $FSTEST_DIR -n $procs -f 4 > /dev/null 2>&1
+ done
+
+ rm -rf $FSTEST_DIR/*
+ rmdir $FSTEST_DIR
+} &
+
i=0
let ITERATIONS=$ITERATIONS-1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2012-09-28 3:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 3:33 Eric Sandeen [this message]
2012-09-28 4:36 ` [PATCH] xfstests 068: Add mmap load Dave Chinner
2012-09-28 9:58 ` Christoph Hellwig
2012-10-01 13:45 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50651A99.1070307@redhat.com \
--to=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox