From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q8SGbYNg258857 for ; Fri, 28 Sep 2012 11:37:34 -0500 Message-ID: <5065D292.4090600@sgi.com> Date: Fri, 28 Sep 2012 11:38:42 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH v2] xfsprog: remove duplicate vector memalign from xfs_io References: <20120925142414.660506845@sgi.com> <20120925142421.398175185@sgi.com> <20120926220434.GG13214@sgi.com> <20120927124742.695778439@sgi.com> <20120927225248.GB25626@dastard> In-Reply-To: <20120927225248.GB25626@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Ben Myers , xfs@oss.sgi.com On 09/27/12 17:52, Dave Chinner wrote: > On Thu, Sep 27, 2012 at 07:47:36AM -0500, Mark Tinguely wrote: >> The vector feature of xfs_io uses its own memory buffer in the iov structure >> and does not use the buffer entry. Remove the duplicate memalign. >> >> v2: removed global buffer in __dump_buffer() and use passed buf pointer per >> Ben's detection. >> >> Signed-off-by: Mark Tinguely >> Reviewed-by: Ben Myers > > Looks good, Thanks for fixing this. > > Reviewed-by: Dave Chinner > Committed to git://oss.sgi.com/xfs/cmds/xfsprogs.git, master branch. --Mark. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs