* [PATCH] xfstests 068: Add mmap load
@ 2012-09-28 3:33 Eric Sandeen
2012-09-28 4:36 ` Dave Chinner
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eric Sandeen @ 2012-09-28 3:33 UTC (permalink / raw)
To: xfs-oss
Test 068 is the go-to test for freeze deadlock coverage;
unfortunately it only uses fsstress, which doesn't do any mmap
IO.
Using the existing fstest binary gets us a cheap mmap exerciser
as well.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I think it's fair to modify this test vs. making a new one -
it's never passed yet, and will only start passing in kernel 3.6,
so it shouldn't cause new test regressions to add mmap ops.
And I can verify that this finds mmap bugs; I had a backport
which messed up ext4's freeze vs. mmap handling, and this exposes
it. :)
diff --git a/068 b/068
index 617420c..a0bf425 100755
--- a/068
+++ b/068
@@ -90,6 +90,21 @@ touch $tmp.running
rmdir $STRESS_DIR
} &
+# start fstest -m loop in a background block; this gets us mmap coverage
+{
+ FSTEST_DIR="$SCRATCH_MNT/fstest_test_dir"
+ mkdir "$FSTEST_DIR"
+
+ procs=2
+ while [ -f "$tmp.running" ]
+ do
+ src/fstest -m -p $FSTEST_DIR -n $procs -f 4 > /dev/null 2>&1
+ done
+
+ rm -rf $FSTEST_DIR/*
+ rmdir $FSTEST_DIR
+} &
+
i=0
let ITERATIONS=$ITERATIONS-1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfstests 068: Add mmap load
2012-09-28 3:33 [PATCH] xfstests 068: Add mmap load Eric Sandeen
@ 2012-09-28 4:36 ` Dave Chinner
2012-09-28 9:58 ` Christoph Hellwig
2012-10-01 13:45 ` Mark Tinguely
2 siblings, 0 replies; 4+ messages in thread
From: Dave Chinner @ 2012-09-28 4:36 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Sep 27, 2012 at 10:33:45PM -0500, Eric Sandeen wrote:
> Test 068 is the go-to test for freeze deadlock coverage;
> unfortunately it only uses fsstress, which doesn't do any mmap
> IO.
>
> Using the existing fstest binary gets us a cheap mmap exerciser
> as well.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> I think it's fair to modify this test vs. making a new one -
> it's never passed yet, and will only start passing in kernel 3.6,
> so it shouldn't cause new test regressions to add mmap ops.
>
> And I can verify that this finds mmap bugs; I had a backport
> which messed up ext4's freeze vs. mmap handling, and this exposes
> it. :)
>
>
> diff --git a/068 b/068
> index 617420c..a0bf425 100755
> --- a/068
> +++ b/068
> @@ -90,6 +90,21 @@ touch $tmp.running
> rmdir $STRESS_DIR
> } &
>
> +# start fstest -m loop in a background block; this gets us mmap coverage
> +{
> + FSTEST_DIR="$SCRATCH_MNT/fstest_test_dir"
> + mkdir "$FSTEST_DIR"
> +
> + procs=2
> + while [ -f "$tmp.running" ]
> + do
> + src/fstest -m -p $FSTEST_DIR -n $procs -f 4 > /dev/null 2>&1
> + done
> +
> + rm -rf $FSTEST_DIR/*
> + rmdir $FSTEST_DIR
> +} &
Looks good.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfstests 068: Add mmap load
2012-09-28 3:33 [PATCH] xfstests 068: Add mmap load Eric Sandeen
2012-09-28 4:36 ` Dave Chinner
@ 2012-09-28 9:58 ` Christoph Hellwig
2012-10-01 13:45 ` Mark Tinguely
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2012-09-28 9:58 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Thu, Sep 27, 2012 at 10:33:45PM -0500, Eric Sandeen wrote:
> Test 068 is the go-to test for freeze deadlock coverage;
> unfortunately it only uses fsstress, which doesn't do any mmap
> IO.
>
> Using the existing fstest binary gets us a cheap mmap exerciser
> as well.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfstests 068: Add mmap load
2012-09-28 3:33 [PATCH] xfstests 068: Add mmap load Eric Sandeen
2012-09-28 4:36 ` Dave Chinner
2012-09-28 9:58 ` Christoph Hellwig
@ 2012-10-01 13:45 ` Mark Tinguely
2 siblings, 0 replies; 4+ messages in thread
From: Mark Tinguely @ 2012-10-01 13:45 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On 09/27/12 22:33, Eric Sandeen wrote:
> Test 068 is the go-to test for freeze deadlock coverage;
> unfortunately it only uses fsstress, which doesn't do any mmap
> IO.
>
> Using the existing fstest binary gets us a cheap mmap exerciser
> as well.
>
> Signed-off-by: Eric Sandeen<sandeen@redhat.com>
> ---
>
> I think it's fair to modify this test vs. making a new one -
> it's never passed yet, and will only start passing in kernel 3.6,
> so it shouldn't cause new test regressions to add mmap ops.
>
> And I can verify that this finds mmap bugs; I had a backport
> which messed up ext4's freeze vs. mmap handling, and this exposes
> it. :)
>
Committed to git://oss.sgi.com/xfs/cmds/xfs.git, master branch.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-10-01 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-28 3:33 [PATCH] xfstests 068: Add mmap load Eric Sandeen
2012-09-28 4:36 ` Dave Chinner
2012-09-28 9:58 ` Christoph Hellwig
2012-10-01 13:45 ` Mark Tinguely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox