* [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag
@ 2012-10-09 19:13 Eric Sandeen
2012-10-09 19:21 ` [PATCH 2/2] xfsprogs: report projid32 status in growfs output Eric Sandeen
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Eric Sandeen @ 2012-10-09 19:13 UTC (permalink / raw)
To: xfs-oss
Matches new flag added to kernel.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/include/xfs_fs.h b/include/xfs_fs.h
index faac5af..0dd3afd 100644
--- a/include/xfs_fs.h
+++ b/include/xfs_fs.h
@@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks {
#define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100 /* log format version 2 */
#define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200 /* sector sizes >1BB */
#define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400 /* inline attributes rework */
-#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */
+#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800 /* 32-bit project IDs */
+#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */
#define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000 /* lazy superblock counters */
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] xfsprogs: report projid32 status in growfs output 2012-10-09 19:13 [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Eric Sandeen @ 2012-10-09 19:21 ` Eric Sandeen 2012-10-09 19:47 ` Dave Chinner 2012-10-09 19:48 ` [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Dave Chinner 2012-10-11 0:00 ` Eric Sandeen 2 siblings, 1 reply; 6+ messages in thread From: Eric Sandeen @ 2012-10-09 19:21 UTC (permalink / raw) To: Eric Sandeen; +Cc: xfs-oss With the projid32 flag now in the FSGEOM ioctl results we can report projid32 status in xfs_growfs / xfs_info output, to match the mkfs.xfs output. However, since the flag was only recently added to the kernel, we may get some incorrect reports of "projid32bit=0" Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- ... and I don't know how big a problem those incorrect reports might be ... diff --git a/growfs/xfs_growfs.c b/growfs/xfs_growfs.c index a6d298b..ca5adcf 100644 --- a/growfs/xfs_growfs.c +++ b/growfs/xfs_growfs.c @@ -62,11 +62,12 @@ report_info( int dirversion, int logversion, int attrversion, - int cimode) + int cimode, + int projid32) { printf(_( "meta-data=%-22s isize=%-6u agcount=%u, agsize=%u blks\n" - " =%-22s sectsz=%-5u attr=%u\n" + " =%-22s sectsz=%-5u attr=%u, projid32bit=%u\n" "data =%-22s bsize=%-6u blocks=%llu, imaxpct=%u\n" " =%-22s sunit=%-6u swidth=%u blks\n" "naming =version %-14u bsize=%-6u ascii-ci=%d\n" @@ -75,7 +76,7 @@ report_info( "realtime =%-22s extsz=%-6u blocks=%llu, rtextents=%llu\n"), mntpoint, geo.inodesize, geo.agcount, geo.agblocks, - "", geo.sectsize, attrversion, + "", geo.sectsize, attrversion, projid32, "", geo.blocksize, (unsigned long long)geo.datablocks, geo.imaxpct, "", geo.sunit, geo.swidth, @@ -117,6 +118,7 @@ main(int argc, char **argv) long long rsize; /* new rt size in fs blocks */ int ci; /* ASCII case-insensitive fs */ int lazycount; /* lazy superblock counters */ + int projid32; /* 32-bit project IDs */ int xflag; /* -x flag */ char *fname; /* mount point name */ char *datadev; /* data device name */ @@ -243,10 +245,11 @@ main(int argc, char **argv) attrversion = geo.flags & XFS_FSOP_GEOM_FLAGS_ATTR2 ? 2 : \ (geo.flags & XFS_FSOP_GEOM_FLAGS_ATTR ? 1 : 0); ci = geo.flags & XFS_FSOP_GEOM_FLAGS_DIRV2CI ? 1 : 0; + projid32 = geo.flags & XFS_FSOP_GEOM_FLAGS_PROJID32 ? 1 : 0; if (nflag) { report_info(geo, datadev, isint, logdev, rtdev, lazycount, dirversion, logversion, - attrversion, ci); + attrversion, ci, projid32); exit(0); } @@ -283,7 +286,7 @@ main(int argc, char **argv) report_info(geo, datadev, isint, logdev, rtdev, lazycount, dirversion, logversion, - attrversion, ci); + attrversion, ci, projid32); ddsize = xi.dsize; dlsize = ( xi.logBBsize? xi.logBBsize : _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] xfsprogs: report projid32 status in growfs output 2012-10-09 19:21 ` [PATCH 2/2] xfsprogs: report projid32 status in growfs output Eric Sandeen @ 2012-10-09 19:47 ` Dave Chinner 0 siblings, 0 replies; 6+ messages in thread From: Dave Chinner @ 2012-10-09 19:47 UTC (permalink / raw) To: Eric Sandeen; +Cc: Eric Sandeen, xfs-oss On Tue, Oct 09, 2012 at 02:21:14PM -0500, Eric Sandeen wrote: > With the projid32 flag now in the FSGEOM ioctl results we > can report projid32 status in xfs_growfs / xfs_info output, > to match the mkfs.xfs output. > > However, since the flag was only recently added to the kernel, > we may get some incorrect reports of "projid32bit=0" > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> > --- > > ... and I don't know how big a problem those incorrect reports > might be ... I doubt it will be a problem - the 32bit projid is pretty self-contained, and we can still get the info from xfs_db if we really need to confirm that it is set. Code looks good. Reviewed-by: Dave Chinner <dchinner@redhat.com> -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag 2012-10-09 19:13 [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Eric Sandeen 2012-10-09 19:21 ` [PATCH 2/2] xfsprogs: report projid32 status in growfs output Eric Sandeen @ 2012-10-09 19:48 ` Dave Chinner 2012-10-11 0:00 ` Eric Sandeen 2 siblings, 0 replies; 6+ messages in thread From: Dave Chinner @ 2012-10-09 19:48 UTC (permalink / raw) To: Eric Sandeen; +Cc: xfs-oss On Tue, Oct 09, 2012 at 02:13:23PM -0500, Eric Sandeen wrote: > Matches new flag added to kernel. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> > --- > > diff --git a/include/xfs_fs.h b/include/xfs_fs.h > index faac5af..0dd3afd 100644 > --- a/include/xfs_fs.h > +++ b/include/xfs_fs.h > @@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks { > #define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100 /* log format version 2 */ > #define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200 /* sector sizes >1BB */ > #define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400 /* inline attributes rework */ > -#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */ > +#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800 /* 32-bit project IDs */ > +#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */ > #define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000 /* lazy superblock counters */ That's an easy one ;) Reviewed-by: Dave Chinner <dchinner@redhat.com> -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag 2012-10-09 19:13 [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Eric Sandeen 2012-10-09 19:21 ` [PATCH 2/2] xfsprogs: report projid32 status in growfs output Eric Sandeen 2012-10-09 19:48 ` [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Dave Chinner @ 2012-10-11 0:00 ` Eric Sandeen 2012-10-11 0:01 ` Eric Sandeen 2 siblings, 1 reply; 6+ messages in thread From: Eric Sandeen @ 2012-10-11 0:00 UTC (permalink / raw) To: Eric Sandeen; +Cc: xfs-oss On 10/9/12 2:13 PM, Eric Sandeen wrote: > Matches new flag added to kernel. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> SGI, can you please add a : Cc: stable@vger.kernel.org when this is committed? New stuff will be depending on this and it'd be good to get it munged into stable kernels as well. Thanks, -Eric > --- > > diff --git a/include/xfs_fs.h b/include/xfs_fs.h > index faac5af..0dd3afd 100644 > --- a/include/xfs_fs.h > +++ b/include/xfs_fs.h > @@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks { > #define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100 /* log format version 2 */ > #define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200 /* sector sizes >1BB */ > #define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400 /* inline attributes rework */ > -#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */ > +#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800 /* 32-bit project IDs */ > +#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */ > #define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000 /* lazy superblock counters */ > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag 2012-10-11 0:00 ` Eric Sandeen @ 2012-10-11 0:01 ` Eric Sandeen 0 siblings, 0 replies; 6+ messages in thread From: Eric Sandeen @ 2012-10-11 0:01 UTC (permalink / raw) To: Eric Sandeen; +Cc: xfs-oss On 10/10/12 7:00 PM, Eric Sandeen wrote: > On 10/9/12 2:13 PM, Eric Sandeen wrote: >> Matches new flag added to kernel. >> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com> > > SGI, can you please add a : > > Cc: stable@vger.kernel.org > > when this is committed? New stuff will be depending on this and it'd be good to get it munged into stable kernels as well. Ugh ignore that responded to the wrong patch :/ -Eric > Thanks, > -Eric > >> --- >> >> diff --git a/include/xfs_fs.h b/include/xfs_fs.h >> index faac5af..0dd3afd 100644 >> --- a/include/xfs_fs.h >> +++ b/include/xfs_fs.h >> @@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks { >> #define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100 /* log format version 2 */ >> #define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200 /* sector sizes >1BB */ >> #define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400 /* inline attributes rework */ >> -#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */ >> +#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800 /* 32-bit project IDs */ >> +#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000 /* ASCII only CI names */ >> #define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000 /* lazy superblock counters */ >> >> _______________________________________________ >> xfs mailing list >> xfs@oss.sgi.com >> http://oss.sgi.com/mailman/listinfo/xfs >> > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-10-11 0:00 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-10-09 19:13 [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Eric Sandeen 2012-10-09 19:21 ` [PATCH 2/2] xfsprogs: report projid32 status in growfs output Eric Sandeen 2012-10-09 19:47 ` Dave Chinner 2012-10-09 19:48 ` [PATCH 1/2] xfsprogs: add PROJID32 geom feature flag Dave Chinner 2012-10-11 0:00 ` Eric Sandeen 2012-10-11 0:01 ` Eric Sandeen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox