From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2] xfs_io: configure tests for preadv/pwritev & sync_file_range
Date: Tue, 09 Oct 2012 17:32:30 -0500 [thread overview]
Message-ID: <5074A5FE.50101@sandeen.net> (raw)
In-Reply-To: <20121009222806.GS23644@dastard>
On 10/9/12 5:28 PM, Dave Chinner wrote:
> On Tue, Oct 09, 2012 at 05:08:26PM -0500, Eric Sandeen wrote:
>> On older systems we may not have preadv/pwritev and/or
>> sync_file_range.
>>
>> Add the configure magic, and stub out the code
>> where needed.
>>
>> (sync_file_range just needed a better test; preadv/pwritev
>> took a little more rearranging)
>>
>> And fix a couple typos ("numberic") while we're at it.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Looks fine, though the "HAVE_PREADV" in the pwritev case is a bit
> wierd. Perhaps doing this:
>
>> diff --git a/include/builddefs.in b/include/builddefs.in
>> index 81ebfcd..4a0e910 100644
>> --- a/include/builddefs.in
>> +++ b/include/builddefs.in
>> @@ -101,6 +101,8 @@ HAVE_GETMNTENT = @have_getmntent@
>> HAVE_GETMNTINFO = @have_getmntinfo@
>> HAVE_FALLOCATE = @have_fallocate@
>> HAVE_FIEMAP = @have_fiemap@
>> +HAVE_PREADV = @have_preadv@
>
> HAVE_PWRITEV = @have_preadv@
>
> Would reduce that wierdness a bit when looking at the pwritev
> code....
Yeah I was a little unhappy w/ that. But I think then we'd also need:
+ifeq ($(HAVE_PWRITEV),yes)
+LCFLAGS += -DHAVE_PWRITEV
+endif
and at some point we might run out of room on the cmdline ;)
Could change it to HAVE_PREADWRITEV or something ...
-Eric
> Otherwise everything else looks ok.
>
> Cheers,
>
> Dave.
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-09 22:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 22:02 [PATCH 1/2] xfs_io: include headers for preadv/pwritev Eric Sandeen
2012-10-09 22:08 ` [PATCH 2/2] xfs_io: configure tests for preadv/pwritev & sync_file_range Eric Sandeen
2012-10-09 22:28 ` Dave Chinner
2012-10-09 22:32 ` Eric Sandeen [this message]
2012-10-09 22:56 ` Dave Chinner
2012-10-09 22:57 ` Eric Sandeen
2012-10-09 23:05 ` Dave Chinner
2012-10-10 3:40 ` [PATCH 2/2 V2] " Eric Sandeen
2012-10-10 23:25 ` Dave Chinner
2012-10-09 22:21 ` [PATCH 1/2] xfs_io: include headers for preadv/pwritev Dave Chinner
2012-10-10 3:37 ` [PATCH 1/2 V2] " Eric Sandeen
2012-10-10 23:24 ` Dave Chinner
2012-10-11 20:40 ` [PATCH 1/2] " Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5074A5FE.50101@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox