Re: [PATCH] xfs_quota: XFS_XFLAG_PROJINHERIT is only for dirs

Christoph Hellwig
2012-10-13T15:50:35Z

On Fri, Oct 12, 2012 at 11:19:55AM -0500, Eric Sandeen wrote:
> xfs_quota has long set XFS_XFLAG_PROJINHERIT on all files,
> and tested for presence on all files. However, Dave's semi-recent
> xfs_repair update is now flagging this as an error:

I think we should rever that part of the repair patch. While there
really is not point to have XFS_XFLAG_PROJINHERIT set on non-directory
files we have been setting it for year, so repair should cope with that.

I'd also like to have a test checking that repair does not complain
about XFS_XFLAG_PROJINHERIT being set on a non-directory to verify this.

For the future I'm fine with not setting it on non-directories anymore,
so:

Reviewed-by: Christoph Hellwig <hch@lst.de>

for this patch after a slight update to the commit message.