Re: [PATCH 3/3] xfsdump: refuse restore of V4 format unless FS has projid32bit set

Rich Johnston
2012-11-09T18:30:08Z

On 10/12/2012 04:42 PM, Eric Sandeen wrote:
> Restoring a dump w/ the top 16 bits of a 32-bit project ID
> set will fail to restore the full ID unless the projid32 feature
> flag is set on the filesystem.
>
> So if the target fs is xfs, fail the restore if we have a version
> 4 dump (only used currently if dumped from a projid32 fs) and
> the target xfs filesystem does not have that feature set.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> p.s. i'd rather go by whether the contents of the dump have any
>> 16 bit project ids than by the feature flag, but I don't see
> a way to do that.
>
> diff --git a/restore/content.c b/restore/content.c

Looks good Eric.
Reviewed-by: Rich Johnston <rjohnston@sgi.com>