[PATCH] xfstests: get return value in seek_sanity_test

[PATCH] xfstests: get return value in seek_sanity_test

[wenqing.lz]

From: Zheng Liu <wenqing.lz@taobao.com>

In seek_sanity_test getting return value is missing.  Thus we couldn't get the
result unless someone read the log file (e.g. # 285).

Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
---
 src/seek_sanity_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
index 34f5508..e3ed64a 100644
--- a/src/seek_sanity_test.c
+++ b/src/seek_sanity_test.c
@@ -676,7 +676,7 @@ int main(int argc, char **argv)
 	for (i = 0; i < numtests; ++i) {
 		if (ret)
 			goto out;
-		run_test(&seek_tests[i]);
+		ret = run_test(&seek_tests[i]);
 	}
 
 out:
-- 
1.7.12.rc2.18.g61b472e

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: get return value in seek_sanity_test

[Jie Liu]

Hi Zheng,

On 10/21/12 19:39, wenqing.lz wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> In seek_sanity_test getting return value is missing.  Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
>  src/seek_sanity_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 34f5508..e3ed64a 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -676,7 +676,7 @@ int main(int argc, char **argv)
>  	for (i = 0; i < numtests; ++i) {
>  		if (ret)
>  			goto out;
> -		run_test(&seek_tests[i]);
> +		ret = run_test(&seek_tests[i]);
Thanks for the patch.
Looks there is another issue regarding the run_test loop, i.e, it should be:

    ret = run_test(&seek_tests[i]);
    if (ret)
        break;

Could you please fix it too?

Thanks,
-Jeff
>  	}
>  
>  out:

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs