From: Jie Liu <jeff.liu@oracle.com>
To: "wenqing.lz" <gnehzuil.liu@gmail.com>
Cc: Zheng Liu <wenqing.lz@taobao.com>, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests: get return value in seek_sanity_test
Date: Sun, 21 Oct 2012 21:13:01 +0800 [thread overview]
Message-ID: <5083F4DD.1090600@oracle.com> (raw)
In-Reply-To: <1350825309-30733-1-git-send-email-wenqing.lz@taobao.com>
On 10/21/12 21:15, wenqing.lz wrote:
> From: Zheng Liu <wenqing.lz@taobao.com>
>
> In seek_sanity_test getting return value is missing. Thus we couldn't get the
> result unless someone read the log file (e.g. # 285).
>
> CC: Jeff Liu <jeff.liu@oracle.com>
> Signed-off-by: Zheng Liu <wenqing.lz@taobao.com>
> ---
> v2 <- v1:
> * put return value check below the run_test()
>
> Hi Jeff,
>
> Could you please review this patch again? Thanks.
>
> Regards,
> Zheng
>
> src/seek_sanity_test.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/seek_sanity_test.c b/src/seek_sanity_test.c
> index 34f5508..3897f02 100644
> --- a/src/seek_sanity_test.c
> +++ b/src/seek_sanity_test.c
> @@ -674,9 +674,9 @@ int main(int argc, char **argv)
> goto out;
>
> for (i = 0; i < numtests; ++i) {
> + ret = run_test(&seek_tests[i]);
> if (ret)
> - goto out;
> - run_test(&seek_tests[i]);
> + break;
> }
>
> out:
Looks good to me, thank you!
-Jeff
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-21 13:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-21 13:15 [PATCH v2] xfstests: get return value in seek_sanity_test wenqing.lz
2012-10-21 13:13 ` Jie Liu [this message]
2012-11-09 3:25 ` Zheng Liu
2012-11-09 5:38 ` Jeff Liu
2012-11-09 14:30 ` Mark Tinguely
2012-11-17 6:06 ` Jeff Liu
2012-11-20 15:26 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5083F4DD.1090600@oracle.com \
--to=jeff.liu@oracle.com \
--cc=gnehzuil.liu@gmail.com \
--cc=wenqing.lz@taobao.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox