From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id q9OKaZhD052955 for ; Wed, 24 Oct 2012 15:36:35 -0500 Message-ID: <50885216.1020201@sgi.com> Date: Wed, 24 Oct 2012 15:39:50 -0500 From: Rich Johnston MIME-Version: 1.0 Subject: Re: [PATCH 1/2] 286: Test FITRIM where length is smaller than FSB References: <1350380494-17482-1-git-send-email-lczerner@redhat.com> <20121016201645.GJ2739@dastard> In-Reply-To: <20121016201645.GJ2739@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Lukas Czerner , xfs@oss.sgi.com Lukas, On 10/16/2012 03:16 PM, Dave Chinner wrote: > On Tue, Oct 16, 2012 at 11:41:33AM +0200, Lukas Czerner wrote: >> This tests corner case in FITRIM implementation where range size is >> smaller than file system block or zero. In this case FITRIM should fail >> with EINVAL. >> >> The problem was spotted in xfs and ext4 where in case of length = 0 the >> 'end' variable underflowed. In case of length smaller than 1 FSB FITRIM >> finished successfully, but we really should rather return EINVAL in both >> cases. >> >> (This patch has to be applied after 'Use upstream version of fstrim >> instead of the local one') >> >> Signed-off-by: Lukas Czerner >> --- >> 286 | 58 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 286.out | 6 ++++++ > > We've already got 286 (and 287), so this should probably be 288... > > Otherwise, it looks good. > > Reviewed-by: Dave Chinner > This has been committed to git://oss.sgi.com/xfs/xfs.git, master and for-next branches. Regards --Rich _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs