From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v3] xfs_io: [v3] add the lseek() SEEK_DATA/SEEK_HOLE support
Date: Fri, 26 Oct 2012 08:31:11 -0500 [thread overview]
Message-ID: <508A909F.10305@sgi.com> (raw)
In-Reply-To: <20121025222914.GE29378@dastard>
On 10/25/12 17:29, Dave Chinner wrote:
> On Thu, Oct 25, 2012 at 09:14:44AM -0500, Mark Tinguely wrote:
>> Add the lseek SEEK_DATA/SEEK_HOLE support into xfs_io.
>> The result from the lseek() call will be printed to the output.
>> For example:
>>
>> xfs_io> lseek -h 609k
>> Type Offset
>> hole 630784
>>
>> v1 -> v2 Add "-a" and "-r" options.
>> Simplify the output.
>> v2 -> v3 Refactor for configure.in -> configure.ac change.
>> SEEK_DATA with -1 offset behaves badly on older Linux.
>> Display error message as "ERR<errno>".
> ....
>> +
>> +#include<linux/fs.h>
>
> I missed this first time around - why is this include necessary?
Take it out and you will find that it contains the
defines for SEEK_DATA/SEEK_HOLE.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-26 13:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20121022213759.033667921@sgi.com>
2012-10-22 21:38 ` [PATCH] xfs_io: add the lseek() SEEK_DATA/SEEK_HOLE support Mark Tinguely
2012-10-22 23:29 ` Dave Chinner
2012-10-23 14:08 ` Mark Tinguely
2012-10-23 20:01 ` [PATCH v2] " Mark Tinguely
2012-10-25 14:14 ` [PATCH v3] xfs_io: [v3] " Mark Tinguely
2012-10-25 22:29 ` Dave Chinner
2012-10-26 13:31 ` Mark Tinguely [this message]
2012-10-29 0:10 ` Dave Chinner
2012-10-23 12:22 ` [PATCH] xfs_io: " Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508A909F.10305@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox