From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: xfstests: resolve symlinked devices to real paths
Date: Fri, 26 Oct 2012 11:46:45 -0500 [thread overview]
Message-ID: <508ABE75.4030703@sgi.com> (raw)
In-Reply-To: <4C0EA21B.8020703@sandeen.net>
On 06/08/2010 03:03 PM, Eric Sandeen wrote:
> If you try running xfstests on lvm volumes which are symlinks,
> it'll fail to run several tests because our _require_scratch
> framework ultimately uses lstat not stat, and does not think
> the lvm device (which is usually a symlink to a dm-X device)
> is a block device. Sigh.
>
> Last try at this - just resolve any symlinked devicenames
> into their realpath(3) in common.config.
>
> This actually seems to work.
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>
> ---
>
>
> diff --git a/common.config b/common.config
> index 926846b..e5b2483 100644
> --- a/common.config
> +++ b/common.config
Looks good
Reviewed-by: Rich Johnston <rjohnston@sgi.com>
Eric,
This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests,
master branch, commit ID d5ea873f.
Thanks
--Rich
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-26 16:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 20:03 [PATCH] xfstests: resolve symlinked devices to real paths Eric Sandeen
2012-10-26 16:46 ` Rich Johnston [this message]
2012-11-19 3:26 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices sat
2012-11-19 3:55 ` Wanlong Gao
2012-11-20 4:06 ` Eric Sandeen
2012-11-20 4:30 ` sat
2012-11-20 5:28 ` Eric Sandeen
2012-11-20 13:53 ` Rich Johnston
2012-11-20 14:05 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508ABE75.4030703@sgi.com \
--to=rjohnston@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox