From: Eric Sandeen <sandeen@sandeen.net>
To: Rich Johnston <rjohnston@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: xfstests 224: test aio hole-fill at 4g
Date: Fri, 26 Oct 2012 12:52:21 -0500 [thread overview]
Message-ID: <508ACDD5.8060107@sandeen.net> (raw)
In-Reply-To: <508AC5DA.2080502@sgi.com>
On 10/26/12 12:18 PM, Rich Johnston wrote:
> On 01/29/2010 02:05 PM, Eric Sandeen wrote:
>> Testcase from Giel de Nijs <giel@vectorwise.com>
>> on linux-ext4 list, ""Possible ext4 data corruption
>> with large files and async I/O," on 29 Jan 2010
>>
>> ext4 put byte offsets in a block offset u32 container
>> in the endio struct, so 4g wrapped to 0 leading to
>> data corruption when the unwritten extent did not
>> get converted.
>>
>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>
>> ---
>
> Hey Eric
>
> Just going through the list trying to clean it up. Is this patch still valid or does one of the other hole tests cover this?
There was some question on the list about whether there should be a dedicated test program to do this, or an AIO addition to xfs_io - that probably needs some thought. AFAIK xfs_io still doesn't know anything about AIO.
I doubt that this particular AIO testcase got covered anywhere else.
-Eric
> Regards
> --Rich
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2012-10-26 17:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 20:05 [PATCH] xfstests 224: test aio hole-fill at 4g Eric Sandeen
2010-01-30 10:55 ` Christoph Hellwig
2010-01-30 16:15 ` Eric Sandeen
2010-01-30 17:25 ` tytso
2010-01-30 18:31 ` Eric Sandeen
2010-01-30 19:11 ` Christoph Hellwig
2010-01-30 19:46 ` Eric Sandeen
2012-10-26 17:18 ` Rich Johnston
2012-10-26 17:52 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=508ACDD5.8060107@sandeen.net \
--to=sandeen@sandeen.net \
--cc=rjohnston@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox