From: Eric Sandeen <sandeen@redhat.com>
To: Ben Myers <bpm@sgi.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsdump:fill in bs_forkoff
Date: Tue, 30 Oct 2012 14:54:29 -0500 [thread overview]
Message-ID: <50903075.6060600@redhat.com> (raw)
In-Reply-To: <20121030194718.GD405@sgi.com>
On 10/30/12 2:47 PM, Ben Myers wrote:
> Hey Eric,
>
> On Thu, Oct 18, 2012 at 11:02:05PM -0500, Eric Sandeen wrote:
>> Upstream, the structure containing bs_forkoff is actually zeroed
>> prior to these functions, but when pulling the patch back to an
>> older xfsdump, we got checksum errors due to an uninitialized
>> bs_forkoff not matching in dump vs. restore.
>>
>> So even though forkoff won't be explicitly restored from
>> a dump, do explicitly set it in these routines to keep checksums
>> happy.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Would you say that this is appropriate for the upcoming release?
Hm.
The zeroing isn't in a really obvious spot, IIRC, so explicitly
filling in all members leaves nothing to chance.
OTOH it's a member that (will/should) never get restored,
so filling it in is a little confusing. What do you think?
I think it should be harmless to functionality either way.
-Eric
> Thanks,
> Ben
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-10-30 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 4:02 [PATCH] xfsdump:fill in bs_forkoff Eric Sandeen
2012-10-23 12:26 ` Christoph Hellwig
2012-10-30 19:47 ` Ben Myers
2012-10-30 19:54 ` Eric Sandeen [this message]
2012-10-31 19:46 ` Ben Myers
2012-11-02 4:35 ` Eric Sandeen
2012-11-02 5:15 ` Dave Chinner
2012-11-02 16:47 ` Ben Myers
2012-11-02 17:24 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50903075.6060600@redhat.com \
--to=sandeen@redhat.com \
--cc=bpm@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox