From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2] xfs_logprint: Handle continued inode transactions
Date: Fri, 02 Nov 2012 09:35:11 -0500 [thread overview]
Message-ID: <5093DA1F.5080305@sandeen.net> (raw)
In-Reply-To: <20121102130425.GB12578@infradead.org>
On 11/2/12 8:04 AM, Christoph Hellwig wrote:
> On Thu, Nov 01, 2012 at 11:32:48AM -0500, Eric Sandeen wrote:
>>
>> Tested by running xfs_logprint of TEST_DEV in xfsprogs
>> after sequential tests; without this change it gets off
>> in the weeds eventually; with this fix, it lasts longer,
>> until it hits some other yet-unfixed logprint bug...
>
> Add this testcase to xfstests, please.
well, "this" isn't really a testcase; it's just running logprint
after every test. And in some cases, esp. if the log has wrapped,
that just fails outright due to unrelated problems.
TBH I'm not sure how to generate a testcase for just this issue.
Any ideas?
>> int
>> -xlog_print_trans_inode(xfs_caddr_t *ptr, int len, int *i, int num_ops)
>> +xlog_print_trans_inode(xfs_caddr_t *ptr, int len, int *i, int num_ops, int continued)
>
> Shouldn't this be a bool?
sure
>> xlog_print_op_header(op_head, i, &ptr);
>> + continued = (XLOG_SET(op_head->oh_flags, XLOG_WAS_CONT_TRANS) ||
>> + XLOG_SET(op_head->oh_flags, XLOG_CONTINUE_TRANS));
>
> I'd also really love to see another cleanup patch to kill the
> XLOG_SET macro. The XLOG_ flags are true flags so they can be replaced
> by a simple op_head->oh_flags & XLOG_FLAG.
hm, yeah, that is odd.
if (*last_was_partial_copy)
ophdr->oh_flags |= (XLOG_END_TRANS|XLOG_WAS_CONT_TRANS);
whereas XLOG_SET tests for one and only one.
-Eric
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-02 14:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 16:22 [PATCH 0/2] xfsdump: 2 fixes Eric Sandeen
2012-11-01 16:26 ` [PATCH 1/2] xfsdump: Handle multiply-logged inode fields Eric Sandeen
2012-11-01 16:33 ` [PATCH 1/2 V2] xfs_logprint: " Eric Sandeen
2012-11-02 13:01 ` Christoph Hellwig
2012-11-02 14:39 ` Eric Sandeen
[not found] ` <20130122175530.GR27055@sgi.com>
[not found] ` <20130122210511.GK2498@dastard>
2013-01-28 20:47 ` Eric Sandeen
2013-01-28 21:31 ` Ben Myers
2012-11-01 16:32 ` [PATCH 2/2] xfs_logprint: Handle continued inode transactions Eric Sandeen
2012-11-02 13:04 ` Christoph Hellwig
2012-11-02 14:35 ` Eric Sandeen [this message]
2012-11-01 16:33 ` [PATCH 0/2] xfs_logprint: 2 fixes Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093DA1F.5080305@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox