From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 1/2 V2] xfs_logprint: Handle multiply-logged inode fields
Date: Fri, 02 Nov 2012 09:39:53 -0500 [thread overview]
Message-ID: <5093DB39.5020409@sandeen.net> (raw)
In-Reply-To: <20121102130132.GA12578@infradead.org>
On 11/2/12 8:01 AM, Christoph Hellwig wrote:
>> I've tested this by a simple test such as creating one
>> file on an selinux box, so that data+attr is set, and
>> logprinting; I've also tested by running logprint after
>> subsequent xfstest runs (although we hit other bugs that
>> way).
>
> Can you add this test to xfstests, please?
Yeah that should be easy enough.
>> +
>> + if (f->ilf_fields & (XFS_ILOG_DEV | XFS_ILOG_UUID)) {
>> + switch (f->ilf_fields & (XFS_ILOG_DEV | XFS_ILOG_UUID)) {
>> + case XFS_ILOG_DEV:
>> + printf(_("DEV inode: no extra region\n"));
>
> The if here looks odd, I think you should follow the style with
> a switch on a masked value as it's done in xlog_recover_inode_pass2()
> in the kernel.
Hm TBH I'm not sure why I left that if in there.
For the DFORK/AFORK case I think the if made sense, but not for
the DEV/UUID case I think. I'll take another look.
> I also reall hate the indentation in this function, can you thrown in
> a preparatory patch to change it to the normal one?
to 8-char tabs? Ok
-Eric
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-02 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 16:22 [PATCH 0/2] xfsdump: 2 fixes Eric Sandeen
2012-11-01 16:26 ` [PATCH 1/2] xfsdump: Handle multiply-logged inode fields Eric Sandeen
2012-11-01 16:33 ` [PATCH 1/2 V2] xfs_logprint: " Eric Sandeen
2012-11-02 13:01 ` Christoph Hellwig
2012-11-02 14:39 ` Eric Sandeen [this message]
[not found] ` <20130122175530.GR27055@sgi.com>
[not found] ` <20130122210511.GK2498@dastard>
2013-01-28 20:47 ` Eric Sandeen
2013-01-28 21:31 ` Ben Myers
2012-11-01 16:32 ` [PATCH 2/2] xfs_logprint: Handle continued inode transactions Eric Sandeen
2012-11-02 13:04 ` Christoph Hellwig
2012-11-02 14:35 ` Eric Sandeen
2012-11-01 16:33 ` [PATCH 0/2] xfs_logprint: 2 fixes Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5093DB39.5020409@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox